public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Jerry Van Baren <gerald.vanbaren@ge.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] fdt: Overwrite /chosen node in bootm if it already exists in the dtb
Date: Fri, 26 Sep 2008 11:06:19 -0400	[thread overview]
Message-ID: <48DCFA6B.1070501@ge.com> (raw)
In-Reply-To: <1222441406-5353-1-git-send-email-sr@denx.de>

Stefan Roese wrote:
> Set force parameter in fdt_chosen() call in do_bootm_linux() call.
> Without this, the chosen node is not overwritten if it already
> exists.
> 
> Signed-off-by: Stefan Roese <sr@denx.de>
> ---
>  lib_ppc/bootm.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/lib_ppc/bootm.c b/lib_ppc/bootm.c
> index 38266e1..5af25dd 100644
> --- a/lib_ppc/bootm.c
> +++ b/lib_ppc/bootm.c
> @@ -145,7 +145,7 @@ int do_bootm_linux(int flag, int argc, char *argv[], bootm_headers_t *images)
>  	 * if the user wants it (the logic is in the subroutines).
>  	 */
>  	if (of_size) {
> -		if (fdt_chosen(of_flat_tree, 0) < 0) {
> +		if (fdt_chosen(of_flat_tree, 1) < 0) {
>  			puts ("ERROR: ");
>  			puts ("/chosen node create failed");
>  			puts (" - must RESET the board to recover.\n");

Acked-by: Gerald Van Baren <vanbaren@cideas.com>

Please apply, Wolfgang, and fix the error in my recollection.  :-)

gvb

      reply	other threads:[~2008-09-26 15:06 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-26 15:03 [U-Boot] [PATCH] fdt: Overwrite /chosen node in bootm if it already exists in the dtb Stefan Roese
2008-09-26 15:06 ` Jerry Van Baren [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48DCFA6B.1070501@ge.com \
    --to=gerald.vanbaren@ge.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox