From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jerry Van Baren <gerald.vanbaren@ge.com>
Date: Mon, 29 Sep 2008 07:49:04 -0400
Subject: [U-Boot] [PATCH] mgcoge,
	mgsuvd: added support for the IVM EEprom.
In-Reply-To: <20080929091014.755A724851@gemini.denx.de>
References: <48E08A41.1090708@denx.de>
	<20080929091014.755A724851@gemini.denx.de>
Message-ID: <48E0C0B0.5090707@ge.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Wolfgang Denk wrote:
> Dear Heiko Schocher,
> 
> In message <48E08A41.1090708@denx.de> you wrote:
>> The EEprom contains some Manufacturerinformation,
>> which are read from u-boot at boot time, and saved
>> in same Environmentvars.
>>
>> Signed-off-by: Heiko Schocher <hs@denx.de>

[snip]

>> +{
>> +	int xcode = 0;
>> +	BTChar cr = '\r';
>> +	/* Semikolon char */
>> +	BTChar sc = ';';
> 
> Come on. Do we really need variables for these? And do you think that
> "sc" is easier to read or understand than ';'?
> 
> Please drop these.
> 
>> +	/* Number of CR found */
>> +	unsigned long crFound = 0;
>> +	/* Current address */
>> +	unsigned long address = INVENTORYDATAADDRESS;
>> +	/* String length */
>> +	unsigned long strSize = 0;
>> +	/* Number of CR to skip */
>> +	unsigned long nbrOfCR = aType;
>> +	/* Semicolon to end */
>> +	int endWithSemikolon = 0;

Nitpick: s/kolon/colon/ (several places).  The mixture of English and 
German is jarring.

Best regards,
gvb