[U-Boot] [PATCH] mgcoge, mgsuvd: added support for the IVM EEprom.

Jerry Van Baren
2008-09-29T11:49:04Z

Wolfgang Denk wrote:
> Dear Heiko Schocher,
>
> In message <48E08A41.1090708@denx.de> you wrote:
>> The EEprom contains some Manufacturerinformation,
>> which are read from u-boot at boot time, and saved
>> in same Environmentvars.
>>
>> Signed-off-by: Heiko Schocher <hs@denx.de>

[snip]

>> +{
>> + int xcode = 0;
>> + BTChar cr = '\r';
>> + /* Semikolon char */
>> + BTChar sc = ';';
>
> Come on. Do we really need variables for these? And do you think that
> "sc" is easier to read or understand than ';'?
>
> Please drop these.
>
>> + /* Number of CR found */
>> + unsigned long crFound = 0;
>> + /* Current address */
>> + unsigned long address = INVENTORYDATAADDRESS;
>> + /* String length */
>> + unsigned long strSize = 0;
>> + /* Number of CR to skip */
>> + unsigned long nbrOfCR = aType;
>> + /* Semicolon to end */
>> + int endWithSemikolon = 0;

Nitpick: s/kolon/colon/ (several places). The mixture of English and
German is jarring.

Best regards,
gvb