public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: richardretanubun <richardretanubun@ruggedcom.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] [83xx] Adds two more ethernet interface to 83xx
Date: Mon, 29 Sep 2008 08:43:24 -0400	[thread overview]
Message-ID: <48E0CD6C.90202@ruggedcom.com> (raw)
In-Reply-To: <20080925232807.4E641248F9@gemini.denx.de>

Wolfgang Denk wrote:

> Dear richardretanubun,
>
> In message <48DC1637.5000707@ruggedcom.com> you wrote:
>> Please disregard V2. V1 is correct, except for this change:
>
> So you will submit a V3?
I am not so sure about it.

This patch came to be when I wanted to make it convenient for using u-boot to test a platform 
with six eth interface without the need of an fdt.
 
However, I seem to have sparked a discussion of a larger scope than I expected. :)

Everyone's comment seems to indicate that streamlining is needed for the network code.
 
I'd hate to muck the existing code some more with more copy-paste just for convenience's sake.

However, if you are ok with V3 being "V1 minus the common/cmd_bdinfo.c #if defined(CONFIG_HAS_ETH0) hunk" 
then I can post this version.

>
> Best regards,
>
> Wolfgang Denk
>
>   
Cheers,

- Richard

  reply	other threads:[~2008-09-29 12:43 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-25 12:53 [U-Boot] [PATCH] [83xx] Adds two more ethernet interface to 83xx richardretanubun
2008-09-25 19:50 ` Kim Phillips
2008-09-25 20:25   ` richardretanubun
2008-09-25 20:45     ` Kim Phillips
2008-09-25 22:08       ` Wolfgang Denk
2008-09-25 21:44     ` [U-Boot] [PATCH v2] " richardretanubun
2008-09-25 22:24       ` Wolfgang Denk
2008-09-25 22:52         ` richardretanubun
2008-09-25 23:28           ` Wolfgang Denk
2008-09-29 12:43             ` richardretanubun [this message]
2008-09-29 13:07               ` Jerry Van Baren
2008-09-29 22:28                 ` [U-Boot] [PATCH v3] " richardretanubun
2008-09-30 16:00                   ` Kim Phillips
2008-09-30 15:58                     ` Jerry Van Baren
2008-09-30 17:02                     ` Ben Warren
2008-10-06  5:12                   ` Ben Warren
2008-10-06 19:31                     ` richardretanubun
2008-10-14  5:53                       ` Ben Warren
2008-09-25 22:24   ` [U-Boot] [PATCH] " Wolfgang Denk
2008-09-25 20:42 ` Jerry Van Baren
2008-09-25 22:17   ` Wolfgang Denk
2008-09-26  3:44 ` Jerry Van Baren
2008-09-26  5:46   ` Wolfgang Denk
2008-09-26  7:21   ` Ben Warren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48E0CD6C.90202@ruggedcom.com \
    --to=richardretanubun@ruggedcom.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox