public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Dirk Behme <dirk.behme@googlemail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 03/12 v2] ARM: OMAP3: Add overo pin mux, omap3 and prototype headers
Date: Sun, 05 Oct 2008 08:56:43 +0200	[thread overview]
Message-ID: <48E8652B.10203@googlemail.com> (raw)
In-Reply-To: <20081005012303.GC14377@game.jcrosoft.org>

Jean-Christophe PLAGNIOL-VILLARD wrote:
> On 12:38 Fri 03 Oct     , dirk.behme at googlemail.com wrote:
> 
>>Subject: [PATCH 03/12 v2] ARM: OMAP3: Add overo pin mux, omap3 and prototype headers
>>
>>From: Dirk Behme <dirk.behme@gmail.com>
>>
>>Add overo pin mux, omap3 and prototype headers
>>
>>Signed-off-by: Dirk Behme <dirk.behme@gmail.com>
>>
>>---
>>Changes in version v2:
>>
>>- Update Overo pin mux to add and pull down X_GATE, by Steve Sakoman.
>>
>> include/asm-arm/arch-omap3/mux.h       |  337 +++++++++++++++++++++++++++++++++
>> include/asm-arm/arch-omap3/omap3.h     |  135 +++++++++++++
>> include/asm-arm/arch-omap3/sys_proto.h |   71 ++++++
>> 3 files changed, 543 insertions(+)
>>
>>Index: u-boot-arm/include/asm-arm/arch-omap3/mux.h
>>===================================================================
>>--- u-boot-arm.orig/include/asm-arm/arch-omap3/mux.h
>>+++ u-boot-arm/include/asm-arm/arch-omap3/mux.h
>>@@ -754,4 +754,341 @@
>> 	MUX_VAL(CP(sdrc_cke0),      (IDIS | PTU | EN  | M0)) /*sdrc_cke0*/\
> 
> Same as before
> please use tab instead of space

Thanks for review. Will do so (for 02/12, too).

> and please be carefull of 80 chards limit

Do you mean now or after replacing spaces with tabs?

I carefully checked and think that at the moment (so the space 
version) has everything < 80 chars. If not, please let me know where 
you found violation.

Well, with tab instead of space most probably it will become hard to 
stay < 80 chars. But I will see what I can do.

Thanks for looking@it,

Dirk

P.S.: When we fix space/tab and the nand issue, will you apply this 
patchset to u-boot-arm next, then?

  reply	other threads:[~2008-10-05  6:56 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-03 10:37 [U-Boot] [PATCH 01/12 v2] ARM: OMAP3: Add pin mux, clock and cpu headers dirk.behme at googlemail.com
2008-10-03 10:37 ` [U-Boot] [PATCH 02/12 v2] ARM: OMAP3: Add i2c, memory and additional pin mux headers dirk.behme at googlemail.com
2008-10-03 10:38   ` [U-Boot] [PATCH 03/12 v2] ARM: OMAP3: Add overo pin mux, omap3 and prototype headers dirk.behme at googlemail.com
2008-10-05  1:23     ` Jean-Christophe PLAGNIOL-VILLARD
2008-10-05  6:56       ` Dirk Behme [this message]
2008-10-05  1:18   ` [U-Boot] [PATCH 02/12 v2] ARM: OMAP3: Add i2c, memory and additional pin mux headers Jean-Christophe PLAGNIOL-VILLARD

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48E8652B.10203@googlemail.com \
    --to=dirk.behme@googlemail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox