From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dirk Behme Date: Tue, 07 Oct 2008 19:55:39 +0200 Subject: [U-Boot] [PATCH 07/12 v2] ARM: OMAP3: Add memory and syslib common files, add NAND support In-Reply-To: <20081007172614.GA3438@loki.buserror.net> References: <48e5f6a5.0305560a.0a0e.ffffe071@mx.google.com> <20081003165203.GA11156@ld0162-tx32.am.freescale.net> <48EB2F0E.4090805@googlemail.com> <20081007172614.GA3438@loki.buserror.net> Message-ID: <48EBA29B.7070602@googlemail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Scott Wood wrote: > On Tue, Oct 07, 2008 at 11:42:38AM +0200, Dirk Behme wrote: > >>>Is it OK if config gets written before control, or if this whole thing >>>gets done out of order with respect to other raw writes? >> >>Hmm. I replaced this with the version from Nishanth's U-Boot v2 (see >>link above). If this isn't ok, can you explain a little more? > > > I was referring to the raw accessors, which you removed, so it's OK. :) >>I.e. with patch in attachment we don't touch nand_base.c any more, but >>still have an #ifdeffed user command in cmd_nand.c. If you don't like >>this, please give a hint how to better do this. > > > If at all possible, fix Linux to accept hardware ECC. Yes, as mentioned by Nishanth, too, this will be possible. But I don't think in the short term, and not with breaking compatibility with kernels already out there. So for the moment I like to have both options, HW & SW ECC. > Otherwise, either add something to the MTD API that the nand command can > call, or have your own board-specific command defined in the board file. > Don't put platform-specific ifdefs in generic files. Do you have any example how to extend MTD API and/or can link to example where board-specific command is already used? Thanks Dirk