public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Ben Warren <biggerbadderben@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH][RESEND] net: ne2000: Divided a function of NE2000 driver
Date: Sun, 12 Oct 2008 21:02:58 -0700	[thread overview]
Message-ID: <48F2C872.20805@gmail.com> (raw)
In-Reply-To: <20081012223200.CC8AE832E405@gemini.denx.de>

Wolfgang Denk wrote:
> Dear Ben,
>
> In message <489BF729.1070707@renesas.com> Nobuhiro Iwamatsu wrote:
>   
>> get_prom function was used __attriute__ , but it is not enable.
>> ax88796.o does not do link besides ne2000.o. When ld is carried
>> out, get_prom function of ax88796.c is ignored.
>> This problem is a thing by specifications of ld.
>> I checked and test this patch on SuperH and MIPS.
>>
>> Signed-off-by: Nobuhiro Iwamatsu <iwamatsu.nobuhiro@renesas.com>
>> ---
>>  drivers/net/Makefile      |    6 +-
>>  drivers/net/ax88796.c     |    2 +-
>>  drivers/net/ne2000.c      |  719 +--------------------------------------------
>>  drivers/net/ne2000_base.h |   36 ++-
>>  4 files changed, 40 insertions(+), 723 deletions(-)
>>     
>
> I think this patch was not added, nor was any feedback sent?
>
> Please comment.
>   
There's been commentary about v2 of this patch within the last couple of 
weeks.  I'm not crazy about it but no better ideas have shown up.  I'll 
pull it in ASAP.

regards,
Ben

      reply	other threads:[~2008-10-13  4:02 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-08  7:35 [U-Boot] [PATCH] net: ne2000: Divided a function of NE2000 driver Nobuhiro Iwamatsu
2008-10-12 22:32 ` [U-Boot] [PATCH][RESEND] " Wolfgang Denk
2008-10-13  4:02   ` Ben Warren [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48F2C872.20805@gmail.com \
    --to=biggerbadderben@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox