public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Jerry Van Baren <gvb.uboot@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [RFC][PATCH v4] bootm: Add sub commands
Date: Mon, 13 Oct 2008 21:38:27 -0400	[thread overview]
Message-ID: <48F3F813.8040706@gmail.com> (raw)
In-Reply-To: <D12270DE-323D-4E4F-B012-DFABB51D4309@kernel.crashing.org>

Kumar Gala wrote:
> 
> On Oct 8, 2008, at 8:48 PM, Jerry Van Baren wrote:
> 
>> Kumar Gala wrote:
>>> * Use new find_cmd_tbl() to process sub-commands
>>>
>>> If this looks good I'll go ahead and clean it up for the other arches 
>>> and OSes.
>>
>> Hi Kumar,
>>
>> Thanks to your sequence hint, interrupt command hint, and one additional
>> piece, I have this working now.
>>
>> The missing piece is reserving memory for the stack before copying the
>> ramdisk to high mem.  It looks like this was lost when you consolidated
>> the machine-specific lib_*/bootm.c do_bootm_linux() functions into one.
>>  Without the reservation code, the copy overwrites the stack.
>> Seriously bad karma.
>>
>> See below for a proof-of-concept hack.
> 
> I think my solution is a bit cleaner for us (adding arch_lmb_reserve).  
> Take a look and see how that works for you.
> 
> - k

Oh yes, my hack was just to verify that reserving the stack space solved 
my problem.  It was not a solution.

Thanks,
gvb

      reply	other threads:[~2008-10-14  1:38 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-23 15:07 [U-Boot] [RFC][PATCH v4] bootm: Add sub commands Kumar Gala
2008-09-29 13:39 ` Kumar Gala
2008-09-29 13:49   ` Jerry Van Baren
2008-10-08  6:04     ` Kumar Gala
2008-10-08 13:17       ` Jerry Van Baren
2008-10-08 13:45         ` Kumar Gala
2008-10-08 14:15           ` Jerry Van Baren
2008-10-08 13:51         ` [U-Boot] [RFC][PATCH v4] bootm: Add sub commands (sequence of commands to replicate bootm) Kumar Gala
2008-10-09  1:48 ` [U-Boot] [RFC][PATCH v4] bootm: Add sub commands Jerry Van Baren
2008-10-13 18:27   ` Kumar Gala
2008-10-13 19:14   ` Kumar Gala
2008-10-14  1:38     ` Jerry Van Baren [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48F3F813.8040706@gmail.com \
    --to=gvb.uboot@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox