From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jerry Van Baren Date: Mon, 13 Oct 2008 21:38:27 -0400 Subject: [U-Boot] [RFC][PATCH v4] bootm: Add sub commands In-Reply-To: References: <1222182462-27755-1-git-send-email-galak@kernel.crashing.org> <48ED62D6.9040100@gmail.com> Message-ID: <48F3F813.8040706@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Kumar Gala wrote: > > On Oct 8, 2008, at 8:48 PM, Jerry Van Baren wrote: > >> Kumar Gala wrote: >>> * Use new find_cmd_tbl() to process sub-commands >>> >>> If this looks good I'll go ahead and clean it up for the other arches >>> and OSes. >> >> Hi Kumar, >> >> Thanks to your sequence hint, interrupt command hint, and one additional >> piece, I have this working now. >> >> The missing piece is reserving memory for the stack before copying the >> ramdisk to high mem. It looks like this was lost when you consolidated >> the machine-specific lib_*/bootm.c do_bootm_linux() functions into one. >> Without the reservation code, the copy overwrites the stack. >> Seriously bad karma. >> >> See below for a proof-of-concept hack. > > I think my solution is a bit cleaner for us (adding arch_lmb_reserve). > Take a look and see how that works for you. > > - k Oh yes, my hack was just to verify that reserving the stack space solved my problem. It was not a solution. Thanks, gvb