public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Wolfgang Grandegger <wg@grandegger.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] 85xx: Using proper I2C source clock divider for MPC8544
Date: Tue, 14 Oct 2008 21:25:34 +0200	[thread overview]
Message-ID: <48F4F22E.5030104@grandegger.com> (raw)
In-Reply-To: <8AC2AC3A-FBEB-45DE-ABC7-E9820098A66D@kernel.crashing.org>

Kumar Gala wrote:
> 
> On Oct 14, 2008, at 2:11 PM, Wolfgang Grandegger wrote:
> 
>> Kumar Gala wrote:
>>> On Oct 10, 2008, at 2:29 AM, Wolfgang Grandegger wrote:
>>>
>>>> Kumar Gala wrote:
>>>>> On Sep 30, 2008, at 3:55 AM, Wolfgang Grandegger wrote:
>>>>>
>>>>>> Measurements with our MPC8544 board showed that the I2C bus
>>>>>> frequency
>>>>>> is wrong by a factor of 1.5. Obviously, the interpretation of the
>>>>>> MPC85xx_PORDEVSR2_SEC_CFG bit of the cfg_sec_freq register is not
>>>>>> correct. There seems to be an error in the 8544 RM.
>>>>>>
>>>>>> Signed-off-by: Wolfgang Grandegger <wg@grandegger.com>
>>>>>> ---
>>>>>> cpu/mpc85xx/speed.c |    4 ++--
>>>>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>>>> can you do me a favor and dump the value of MPC85xx_PORDEVSR2.  Also
>>>>> can you tell me what rev 8544 you have.
>>>> See below:
>>>>
>>>> pordevsr2 at e00e0014=0x8f00007d
>>>>
>>>> CPU:   8544E, Version: 1.1, (0x803c0111)
>>>> Core:  E500, Version: 2.2, (0x80210022)
>>>> Clock Configuration:
>>>>        CPU: 667 MHz, CCB: 334 MHz,
>>>>        DDR: 167 MHz (334 MT/s data rate), LBC:  41 MHz
>>>> L1:    D-cache 32 kB enabled
>>>>        I-cache 32 kB enabled
>>>> Board: Socrates
>>>>
>>>> Wolfgang.
>>>
>>> thanks.  How did you do the measurements that got you this 1.5x factor?
>>
>> This afternoon I re-measured the I2C bus clock frequency with the
>> oscilloscope at the I2C clock line on our Socrates MPC8544 board. With
>> the patch applied, I measured the correct frequency of 100 kHz. Without,
>> it was a factor of 1.5 too high.
> 
> are you able to change cfg_seq_freq on the board?

At least I don't know how. It's defined via hardware strap, I imagine.

Wolfgang.

  reply	other threads:[~2008-10-14 19:25 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-30  8:55 [U-Boot] [PATCH] 85xx: Using proper I2C source clock divider for MPC8544 Wolfgang Grandegger
2008-10-10  3:30 ` Kumar Gala
2008-10-10  7:29   ` Wolfgang Grandegger
2008-10-10 14:09     ` Kumar Gala
2008-10-10 15:16       ` Wolfgang Grandegger
2008-10-14 19:11       ` Wolfgang Grandegger
2008-10-14 19:10         ` Kumar Gala
2008-10-14 19:25           ` Wolfgang Grandegger [this message]
2008-10-14 21:04             ` Kumar Gala
2008-10-14 21:38               ` Wolfgang Grandegger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48F4F22E.5030104@grandegger.com \
    --to=wg@grandegger.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox