[U-Boot] [PATCH v2 02/16] [PATCH] I2C: add new command i2c reset.

[U-Boot] [PATCH v2 02/16] [PATCH] I2C: add new command i2c reset.

[Heiko Schocher]

If I2C Bus is blocked (see doc/I2C_Edge_Conditions),
it is not possible to get out of this, until the
complete Hardware gets a reset. This new commando
calls again i2c_init (and that calls i2c_init_board
if defined), which will deblock the I2C Bus.

Signed-off-by: Heiko Schocher <hs@denx.de>
---
 common/cmd_i2c.c |    9 +++++++++
 1 files changed, 9 insertions(+), 0 deletions(-)

diff --git a/common/cmd_i2c.c b/common/cmd_i2c.c
index ea80e8a..c0afd11 100644
--- a/common/cmd_i2c.c
+++ b/common/cmd_i2c.c
@@ -1182,6 +1182,12 @@ int do_sdram (cmd_tbl_t * cmdtp, int flag, int argc, char *argv[])
 #endif

 #if defined(CONFIG_I2C_CMD_TREE)
+int do_i2c_reset(cmd_tbl_t * cmdtp, int flag, int argc, char *argv[])
+{
+	i2c_init (CFG_I2C_SPEED, CFG_I2C_SLAVE);
+	return 0;
+}
+
 #if defined(CONFIG_I2C_MULTI_BUS)
 int do_i2c_bus_num(cmd_tbl_t * cmdtp, int flag, int argc, char *argv[])
 {
@@ -1238,6 +1244,8 @@ int do_i2c(cmd_tbl_t * cmdtp, int flag, int argc, char *argv[])
 		return do_i2c_crc(cmdtp, flag, --argc, ++argv);
 	if (!strncmp(argv[1], "pr", 2))
 		return do_i2c_probe(cmdtp, flag, --argc, ++argv);
+	if (!strncmp(argv[1], "re", 2))
+		return do_i2c_reset(cmdtp, flag, --argc, ++argv);
 	if (!strncmp(argv[1], "lo", 2))
 		return do_i2c_loop(cmdtp, flag, --argc, ++argv);
 #if defined(CONFIG_CMD_SDRAM)
@@ -1266,6 +1274,7 @@ U_BOOT_CMD(
 	"i2c nm chip address[.0, .1, .2] - write to I2C device (constant address)\n"
 	"i2c crc32 chip address[.0, .1, .2] count - compute CRC32 checksum\n"
 	"i2c probe - show devices on the I2C bus\n"
+	"i2c reset - reinit the I2C Controller\n"
 	"i2c loop chip address[.0, .1, .2] [# of objects] - looping read of device\n"
 #if defined(CONFIG_CMD_SDRAM)
 	"i2c sdram chip - print SDRAM configuration information\n"
-- 
1.5.6.1

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

[U-Boot] [PATCH v2 02/16] [PATCH] I2C: add new command i2c reset.

[Ben Warren]

Heiko Schocher wrote:
> If I2C Bus is blocked (see doc/I2C_Edge_Conditions),
> it is not possible to get out of this, until the
> complete Hardware gets a reset. This new commando
>   
You mean a commando like Chuck Norris?  Seriously, you use this word in 
a lot of these patches and it's not quite appropriate.
> calls again i2c_init (and that calls i2c_init_board
> if defined), which will deblock the I2C Bus.
>
> Signed-off-by: Heiko Schocher <hs@denx.de>
> ---
>  common/cmd_i2c.c |    9 +++++++++
>  1 files changed, 9 insertions(+), 0 deletions(-)
>
> diff --git a/common/cmd_i2c.c b/common/cmd_i2c.c
> index ea80e8a..c0afd11 100644
> --- a/common/cmd_i2c.c
> +++ b/common/cmd_i2c.c
> @@ -1182,6 +1182,12 @@ int do_sdram (cmd_tbl_t * cmdtp, int flag, int argc, char *argv[])
>  #endif
>
>  #if defined(CONFIG_I2C_CMD_TREE)
> +int do_i2c_reset(cmd_tbl_t * cmdtp, int flag, int argc, char *argv[])
> +{
> +	i2c_init (CFG_I2C_SPEED, CFG_I2C_SLAVE);
> +	return 0;
> +}
> +
>  #if defined(CONFIG_I2C_MULTI_BUS)
>  int do_i2c_bus_num(cmd_tbl_t * cmdtp, int flag, int argc, char *argv[])
>  {
> @@ -1238,6 +1244,8 @@ int do_i2c(cmd_tbl_t * cmdtp, int flag, int argc, char *argv[])
>  		return do_i2c_crc(cmdtp, flag, --argc, ++argv);
>  	if (!strncmp(argv[1], "pr", 2))
>  		return do_i2c_probe(cmdtp, flag, --argc, ++argv);
> +	if (!strncmp(argv[1], "re", 2))
> +		return do_i2c_reset(cmdtp, flag, --argc, ++argv);
>  	if (!strncmp(argv[1], "lo", 2))
>  		return do_i2c_loop(cmdtp, flag, --argc, ++argv);
>  #if defined(CONFIG_CMD_SDRAM)
> @@ -1266,6 +1274,7 @@ U_BOOT_CMD(
>  	"i2c nm chip address[.0, .1, .2] - write to I2C device (constant address)\n"
>  	"i2c crc32 chip address[.0, .1, .2] count - compute CRC32 checksum\n"
>  	"i2c probe - show devices on the I2C bus\n"
> +	"i2c reset - reinit the I2C Controller\n"
>   
re-init or re-initialize would be better.
>  	"i2c loop chip address[.0, .1, .2] [# of objects] - looping read of device\n"
>  #if defined(CONFIG_CMD_SDRAM)
>  	"i2c sdram chip - print SDRAM configuration information\n"
>   
regards,
Ben

[U-Boot] [PATCH v2 02/16] [PATCH] I2C: add new command i2c reset.

[Heiko Schocher]

Hello Ben,

Ben Warren wrote:
> Heiko Schocher wrote:
[...]
>>      "i2c probe - show devices on the I2C bus\n"
>> +    "i2c reset - reinit the I2C Controller\n"
>>   
> re-init or re-initialize would be better.

You are right (as I wrote in the help text ...)

Is "i2c reinit" as commandname ok?

bye
Heiko
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

[U-Boot] [PATCH v2 02/16] [PATCH] I2C: add new command i2c reset.

[Ben Warren]

Hi Heiko,

Heiko Schocher wrote:
> Hello Ben,
>
> Ben Warren wrote:
>   
>> Heiko Schocher wrote:
>>     
> [...]
>   
>>>      "i2c probe - show devices on the I2C bus\n"
>>> +    "i2c reset - reinit the I2C Controller\n"
>>>   
>>>       
>> re-init or re-initialize would be better.
>>     
>
> You are right (as I wrote in the help text ...)
>
> Is "i2c reinit" as commandname ok?
>
> bye
> Heiko
>   
I don't have a problem with 'i2c reset' or 'i2c reinit' as commands, 
since it's best to not have punctuation symbols in commands, but in the 
help text we should use proper words, either 'reset', 're-init' or 
're-initialize'.

regards,
Ben

[U-Boot] [PATCH v2 02/16] [PATCH] I2C: add new command i2c reset.

[Heiko Schocher]

Hello Ben,

Ben Warren wrote:
> Heiko Schocher wrote:
>> Hello Ben,
>>
>> Ben Warren wrote:
>>  
>>> Heiko Schocher wrote:
>>>     
>> [...]
>>  
>>>>      "i2c probe - show devices on the I2C bus\n"
>>>> +    "i2c reset - reinit the I2C Controller\n"
>>>>         
>>> re-init or re-initialize would be better.
>>>     
>>
>> You are right (as I wrote in the help text ...)
>>
>> Is "i2c reinit" as commandname ok?
>>
>> bye
>> Heiko
>>   
> I don't have a problem with 'i2c reset' or 'i2c reinit' as commands,
> since it's best to not have punctuation symbols in commands, but in the
> help text we should use proper words, either 'reset', 're-init' or
> 're-initialize'.

Ah, okay. Then I fix just the help text, thanks.

bye
Heiko
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

[U-Boot] [PATCH v2 02/16] [PATCH] I2C: add new command i2c reset.

[Wolfgang Denk]

Dear Ben Warren,

In message <48F76E78.6020500@gmail.com> you wrote:
> 
> > You are right (as I wrote in the help text ...)
> >
> > Is "i2c reinit" as commandname ok?

Please stick with "i2c reset"

Nad, Heiko: in English, it's "command name".

> I don't have a problem with 'i2c reset' or 'i2c reinit' as commands, 
> since it's best to not have punctuation symbols in commands, but in the 
> help text we should use proper words, either 'reset', 're-init' or 
> 're-initialize'.

ACK.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
1000 pains                                              = 1 Megahertz