From: Shinya Kuribayashi <skuribay@ruby.dti.ne.jp>
To: u-boot@lists.denx.de
Subject: [U-Boot] net: Move initialization of Au1x00 SoC ethernet MAC to cpu_eth_init
Date: Sun, 19 Oct 2008 11:51:15 +0900 [thread overview]
Message-ID: <48FAA0A3.2020703@ruby.dti.ne.jp> (raw)
In-Reply-To: <f8328f7c0810181942o7b88ead4g909ece318523da3a@mail.gmail.com>
Ben Warren wrote:
> diff --git a/cpu/mips/cpu.c b/cpu/mips/cpu.c
> index 38d8697..c70cf0b 100644
> --- a/cpu/mips/cpu.c
> +++ b/cpu/mips/cpu.c
>
>
> Please add #include "netdev.h" to top of this file.
Oops, will fix.
> @@ -73,3 +73,10 @@ void write_one_tlb(int index, u32 pagemask, u32
> hi, u32 low0, u32 low1)
> write_c0_index(index);
> tlb_write_indexed();
> }
> +
> +int cpu_eth_init(bd_t *bis)
> +{
> +#ifdef CONFIG_SOC_AU1X00
> + return au1x00_enet_initialize(bis);
> +#endif
> +}
>
> This will warn/error if CONFIG_SOC_AU1X00 isn't defined. I recommend
> something like:
>
> int cpu_eth_init(bd_t *bis)
> {
> int rc = 0;
> #ifdef CONFIG_SCO_AU1X00
> rc = au1x00_enet_initialize(bis);
> #endif
> return rc;
> }
Ok. Updated patch will follow soon.
Thanks for your comments,
Shinya
next prev parent reply other threads:[~2008-10-19 2:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-19 2:31 [U-Boot] net: Move initialization of Au1x00 SoC ethernet MAC to cpu_eth_init Shinya Kuribayashi
2008-10-19 2:42 ` Ben Warren
2008-10-19 2:51 ` Shinya Kuribayashi [this message]
2008-10-19 3:08 ` [U-Boot] [PATCH rev2] " Shinya Kuribayashi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48FAA0A3.2020703@ruby.dti.ne.jp \
--to=skuribay@ruby.dti.ne.jp \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox