From mboxrd@z Thu Jan  1 00:00:00 1970
From: Shinya Kuribayashi <skuribay@ruby.dti.ne.jp>
Date: Sun, 19 Oct 2008 11:51:15 +0900
Subject: [U-Boot] net: Move initialization of Au1x00 SoC ethernet MAC to
	cpu_eth_init
In-Reply-To: <f8328f7c0810181942o7b88ead4g909ece318523da3a@mail.gmail.com>
References: <48FA9C14.3070903@ruby.dti.ne.jp>
	<f8328f7c0810181942o7b88ead4g909ece318523da3a@mail.gmail.com>
Message-ID: <48FAA0A3.2020703@ruby.dti.ne.jp>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Ben Warren wrote:
>     diff --git a/cpu/mips/cpu.c b/cpu/mips/cpu.c
>     index 38d8697..c70cf0b 100644
>     --- a/cpu/mips/cpu.c
>     +++ b/cpu/mips/cpu.c
> 
> 
> Please add #include "netdev.h" to top of this file.

Oops, will fix.

>     @@ -73,3 +73,10 @@ void write_one_tlb(int index, u32 pagemask, u32
>     hi, u32 low0, u32 low1)
>            write_c0_index(index);
>            tlb_write_indexed();
>     }
>     +
>     +int cpu_eth_init(bd_t *bis)
>     +{
>     +#ifdef CONFIG_SOC_AU1X00
>     +       return au1x00_enet_initialize(bis);
>     +#endif
>     +}
> 
> This will warn/error if CONFIG_SOC_AU1X00 isn't defined.  I recommend 
> something like:
> 
> int cpu_eth_init(bd_t *bis)
> {
>         int rc = 0;
> #ifdef CONFIG_SCO_AU1X00
>         rc = au1x00_enet_initialize(bis);
> #endif
>         return rc;
> }

Ok.  Updated patch will follow soon.

Thanks for your comments,

  Shinya