public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Jerry Van Baren <gvb.uboot@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] FDT include file problems
Date: Mon, 20 Oct 2008 06:17:23 -0400	[thread overview]
Message-ID: <48FC5AB3.10302@gmail.com> (raw)
In-Reply-To: <20081020072341.BC464835697A@gemini.denx.de>

Wolfgang Denk wrote:
> Dear Jerry Van Baren,
> 
> In message <20081020031023.GA18173@cideas.com> you wrote:
>>> ...
>>> In file included from /home/wd/git/u-boot/include/libfdt_env.h:33,
>>>                  from fdt.c:51:
>>> /usr/include/asm/byteorder.h:6:2: warning: #warning using private kernel header; include <endian.h> instead!
> ...
> 
>> Does this work better?
> 
> Not really:

[snip]

>> diff --git a/include/libfdt_env.h b/include/libfdt_env.h
>> index 671c3a8..728a248 100644
>> --- a/include/libfdt_env.h
>> +++ b/include/libfdt_env.h
>> @@ -33,10 +33,17 @@
>>  #include <asm/byteorder.h>
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> 
> This has not changed?

Oops, I was rushing too much.  I missed changing this to endian.h.

[snip]

> If I change the code to include <asm/byteorder.h> only for the U-Boot
> code but use <endian.h>, I get warnings:
> 
> ../include/libfdt.h:162: warning: implicit declaration of function '__swab32'
> 
> and finally a "undefined reference to `__swab32'" error. Seems
> __swab32 and __swab64 are defined only in linux/byteorder/swab.h
> 
> Best regards,
> 
> Wolfgang Denk

...and if I were not rushing so much, I would have found that myself 
instead of looking stupid.  :-(

Google hasn't been very helpful for answering the question of how to 
handle endian issues in userland (non-kernel) code.  Hmmm.  Grrr.  Maybe 
I'm not asking it the right question.

Maybe we need to make our own copy of linux/byteorder/swab.h in u-boot? 
  That doesn't seem right.

Best regards,
gvb

  reply	other threads:[~2008-10-20 10:17 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-19 22:01 [U-Boot] FDT include file problems Wolfgang Denk
2008-10-20  3:10 ` Jerry Van Baren
2008-10-20  7:23   ` Wolfgang Denk
2008-10-20 10:17     ` Jerry Van Baren [this message]
2008-10-20 10:51       ` Wolfgang Denk
2008-10-20 11:08       ` Wolfgang Denk
2008-10-20 23:43         ` Jerry Van Baren
2008-10-21  9:24           ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48FC5AB3.10302@gmail.com \
    --to=gvb.uboot@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox