From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jerry Van Baren Date: Mon, 20 Oct 2008 09:02:18 -0400 Subject: [U-Boot] [PATCH 2/2][for v2008.10] 85xx: Using proper I2C source clock divider for MPC8544 In-Reply-To: <48F8F7FF.1040502@freescale.com> References: <1224212330-14491-1-git-send-email-galak@kernel.crashing.org> <1224212330-14491-2-git-send-email-galak@kernel.crashing.org> <940DD369-F390-4CCB-8748-78B7492CC17D@kernel.crashing.org> <48F8F7FF.1040502@freescale.com> Message-ID: <48FC815A.90501@ge.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Timur Tabi wrote: > Kumar Gala wrote: > >>> How about adding a comment that the RM is wrong? Any time the code >>> disagrees with the RM, it *has* to be documented. >> Its documented in the commit. > > Sorry, but that's just not good enough for me. I *hate* it when people say that > it is. > > When I'm looking at some code, and I don't understand what it does, the last > thing I'm doing to do is scour through the git log trying to find some > explanation. > > Would it really have been so hard to add this line? > > /* The MPC8544 RM says it's bit 26, but it's really bit 28 */ I have to agree with Timur, we *need* a comment in the source code for future reference. The git log is good, but not sufficient. Thanks, gvb