From: Ilko Iliev <iliev@ronetix.at>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] at91: board specific lowlevel_init.S
Date: Tue, 21 Oct 2008 18:00:32 +0200 [thread overview]
Message-ID: <48FDFCA0.4090608@ronetix.at> (raw)
In-Reply-To: <20081021135853.C5D84835694E@gemini.denx.de>
Wolfgang Denk wrote:
> Dear Ilko Iliev,
>
> In message <48FDDC1C.2080808@ronetix.at> you wrote:
>
>> This patch allows to have an at91 board specific lowlevel_init.S
>>
>> Signed-off-by: Ilko Iliev <iliev@ronetix.at>
>>
>> index ec6ad5d..7882e89 100644
>> --- a/cpu/arm926ejs/at91/lowlevel_init.S
>> +++ b/cpu/arm926ejs/at91/lowlevel_init.S
>> @@ -27,7 +27,7 @@
>> #include <config.h>
>> #include <version.h>
>>
>> -#ifndef CONFIG_SKIP_LOWLEVEL_INIT
>> +#if !defined(CONFIG_SKIP_LOWLEVEL_INIT) &&
>> !defined(CONFIG_USER_LOWLEVEL_INIT)
>>
>> .globl lowlevel_init
>> lowlevel_init:
>> @@ -39,5 +39,5 @@ lowlevel_init:
>> mov pc, lr
>>
>> .ltorg
>> -
>> -#endif /* CONFIG_SKIP_LOWLEVEL_INIT */
>> +
>> +#endif /* !CONFIG_SKIP_LOWLEVEL_INIT && !CONFIG_USER_LOWLEVEL_INIT */
>>
>
> Maybe instead of adding mor #ifdef'ery here, we can turn
> lowlevel_init() into a "weak" function that can be redefined by board
> specific code?
The lowlevel_init() is an assembler function called from another
assembler function and the attribute .weak doesn't work.
There are no assembler file in the U-BOOT tree which use weak functions.
Do you know how can I make an assembler function weak?
best regards,
Ilko Iilev
next prev parent reply other threads:[~2008-10-21 16:00 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-21 13:41 [U-Boot] [PATCH] at91: board specific lowlevel_init.S Ilko Iliev
2008-10-21 13:58 ` Wolfgang Denk
2008-10-21 16:00 ` Ilko Iliev [this message]
2008-10-21 16:43 ` Jean-Christophe PLAGNIOL-VILLARD
2008-10-21 19:08 ` Wolfgang Denk
2008-10-22 11:12 ` Ilko Iliev
2008-10-22 12:41 ` Jean-Christophe PLAGNIOL-VILLARD
2008-10-22 13:07 ` Ilko Iliev
2008-10-22 13:22 ` Jean-Christophe PLAGNIOL-VILLARD
2008-10-22 14:01 ` Ilko Iliev
2008-10-22 15:06 ` Jean-Christophe PLAGNIOL-VILLARD
2008-10-22 15:49 ` Ilko Iliev
2008-10-27 15:52 ` Ilko Iliev
2008-10-27 16:27 ` Ben Warren
2008-10-27 16:43 ` Jean-Christophe PLAGNIOL-VILLARD
2008-10-27 17:44 ` Ilko Iliev
2008-10-27 21:27 ` Wolfgang Denk
2008-10-27 21:20 ` Wolfgang Denk
2008-10-28 6:24 ` Jean-Christophe PLAGNIOL-VILLARD
2008-10-28 11:45 ` Ilko Iliev
2008-10-30 20:47 ` Jean-Christophe PLAGNIOL-VILLARD
2008-11-05 17:29 ` Ilko Iliev
2008-11-05 17:37 ` Jean-Christophe PLAGNIOL-VILLARD
2008-11-05 21:33 ` Wolfgang Denk
2008-11-06 15:03 ` Ilko Iliev
2008-11-06 15:07 ` Ilko Iliev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48FDFCA0.4090608@ronetix.at \
--to=iliev@ronetix.at \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox