public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Jerry Van Baren <gerald.vanbaren@ge.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] bootm: Add subcommands
Date: Tue, 21 Oct 2008 15:44:20 -0400	[thread overview]
Message-ID: <48FE3114.3040908@ge.com> (raw)
In-Reply-To: <1224520091-26756-1-git-send-email-galak@kernel.crashing.org>

Kumar Gala wrote:
> Add the ability to break the steps of the bootm command into several
> subcommands: start, loados, ramdisk, fdt, bdt, cmdline, prep, go.
> 
> This allows us to do things like manipulate device trees before
> they are passed to a booting kernel or setup memory for a secondary
> core in multicore situations.
> 
> Not all OS types support all subcommands (currently only start, loados,
> ramdisk, fdt, and go are supported).
> 
> Signed-off-by: Kumar Gala <galak@kernel.crashing.org>

Hi Kumar,

I've been hacking at cmd_bootm.c and image.c.  The direction I'm hacking 
in is:
* Move boot_* stuff from image.c into cmd_bootm.c
   - Calling out to another file to a function unused in that file? Ugly.
* Move the FIT stuff out of image.c into a new file fit_image.c
   - The resulting files are more cohesive and less BIG.
* Move the im* commands out of cmd_bootm.c into a new file cmd_image.c
   - At one time, I was of the opinion that "bootm (loados|ramdisk|fdt)"
       should be "ldimage (os|ramdisk|fdt)".  I'm less sure of myself,
       but have not totally discarded the opinion.
   - Looking in cmd_bootm.c for im* commands is rather unintuitive.

My intent is to do this hacking based on your bootm subcommand changes, 
so we can do a two-step cleanup.

Do you have a git repo I can clone rather than trying to keep up with 
the master repo + your patches?  My tracking of your work is falling 
apart.  I see you have an out-of-date repo on git.kernel.org, can you 
update that perhaps?

Thanks,
gvb

  parent reply	other threads:[~2008-10-21 19:44 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-20 16:28 [U-Boot] [PATCH 1/2] bootm: Add subcommands Kumar Gala
2008-10-20 16:28 ` [U-Boot] [PATCH 2/2] bootm: support subcommands in linux ppc bootm Kumar Gala
2008-10-21 19:30 ` [U-Boot] [PATCH 1/2] bootm: Add subcommands Wolfgang Denk
2008-10-21 22:22   ` Kumar Gala
2008-10-22 11:32     ` Jerry Van Baren
2008-10-21 19:44 ` Jerry Van Baren [this message]
2008-10-21 19:50   ` Wolfgang Denk
2008-10-21 19:51     ` Jerry Van Baren
2008-10-21 20:05       ` Wolfgang Denk
2008-10-21 20:07         ` Jerry Van Baren
2008-10-21 23:04   ` Kumar Gala
2008-10-22 11:35     ` Jerry Van Baren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48FE3114.3040908@ge.com \
    --to=gerald.vanbaren@ge.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox