From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jerry Van Baren Date: Tue, 21 Oct 2008 15:44:20 -0400 Subject: [U-Boot] [PATCH 1/2] bootm: Add subcommands In-Reply-To: <1224520091-26756-1-git-send-email-galak@kernel.crashing.org> References: <1224520091-26756-1-git-send-email-galak@kernel.crashing.org> Message-ID: <48FE3114.3040908@ge.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Kumar Gala wrote: > Add the ability to break the steps of the bootm command into several > subcommands: start, loados, ramdisk, fdt, bdt, cmdline, prep, go. > > This allows us to do things like manipulate device trees before > they are passed to a booting kernel or setup memory for a secondary > core in multicore situations. > > Not all OS types support all subcommands (currently only start, loados, > ramdisk, fdt, and go are supported). > > Signed-off-by: Kumar Gala Hi Kumar, I've been hacking at cmd_bootm.c and image.c. The direction I'm hacking in is: * Move boot_* stuff from image.c into cmd_bootm.c - Calling out to another file to a function unused in that file? Ugly. * Move the FIT stuff out of image.c into a new file fit_image.c - The resulting files are more cohesive and less BIG. * Move the im* commands out of cmd_bootm.c into a new file cmd_image.c - At one time, I was of the opinion that "bootm (loados|ramdisk|fdt)" should be "ldimage (os|ramdisk|fdt)". I'm less sure of myself, but have not totally discarded the opinion. - Looking in cmd_bootm.c for im* commands is rather unintuitive. My intent is to do this hacking based on your bootm subcommand changes, so we can do a two-step cleanup. Do you have a git repo I can clone rather than trying to keep up with the master repo + your patches? My tracking of your work is falling apart. I see you have an out-of-date repo on git.kernel.org, can you update that perhaps? Thanks, gvb