From: Jerry Van Baren <gerald.vanbaren@ge.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] bootm: Add subcommands
Date: Wed, 22 Oct 2008 07:35:33 -0400 [thread overview]
Message-ID: <48FF1005.4000009@ge.com> (raw)
In-Reply-To: <F042C652-7B7C-4229-A1B0-5D16B56DFE00@kernel.crashing.org>
Kumar Gala wrote:
>
> On Oct 21, 2008, at 2:44 PM, Jerry Van Baren wrote:
>
>>
>> I've been hacking at cmd_bootm.c and image.c. The direction I'm
>> hacking in is:
>> * Move boot_* stuff from image.c into cmd_bootm.c
>> - Calling out to another file to a function unused in that file? Ugly.
>> * Move the FIT stuff out of image.c into a new file fit_image.c
>> - The resulting files are more cohesive and less BIG.
>> * Move the im* commands out of cmd_bootm.c into a new file cmd_image.c
>> - At one time, I was of the opinion that "bootm (loados|ramdisk|fdt)"
>> should be "ldimage (os|ramdisk|fdt)". I'm less sure of myself,
>> but have not totally discarded the opinion.
>> - Looking in cmd_bootm.c for im* commands is rather unintuitive.
>
> these all sound like good things. I've posted a "clean" patchset for
> Wolfgang to apply to 'master' or 'testing'
>
> - k
Thanks, that was helpful. I cloned the testing branch and am hacking
merrily.
gvb
prev parent reply other threads:[~2008-10-22 11:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-20 16:28 [U-Boot] [PATCH 1/2] bootm: Add subcommands Kumar Gala
2008-10-20 16:28 ` [U-Boot] [PATCH 2/2] bootm: support subcommands in linux ppc bootm Kumar Gala
2008-10-21 19:30 ` [U-Boot] [PATCH 1/2] bootm: Add subcommands Wolfgang Denk
2008-10-21 22:22 ` Kumar Gala
2008-10-22 11:32 ` Jerry Van Baren
2008-10-21 19:44 ` Jerry Van Baren
2008-10-21 19:50 ` Wolfgang Denk
2008-10-21 19:51 ` Jerry Van Baren
2008-10-21 20:05 ` Wolfgang Denk
2008-10-21 20:07 ` Jerry Van Baren
2008-10-21 23:04 ` Kumar Gala
2008-10-22 11:35 ` Jerry Van Baren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48FF1005.4000009@ge.com \
--to=gerald.vanbaren@ge.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox