From: Jerry Van Baren <gerald.vanbaren@ge.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] ppc4xx: New board avnet fx12 minimodule <v2>
Date: Wed, 22 Oct 2008 08:01:38 -0400 [thread overview]
Message-ID: <48FF1622.9050905@ge.com> (raw)
In-Reply-To: <1224667538-25556-1-git-send-email-schardt@team-ctech.de>
Georg Schardt wrote:
> From: schardt <schardt@team-ctech.de>
>
> this patch adds support for the avnet fx12 minimodul
> it needs the "ppc4xx: Generic architecture for xilinx ppc405" patch from Ricardo
>
> <v2>
> rebased to ppc4xx/master
The above two^Wfour lines should go *below* the "---", they are remarks
WRT the patch, not really a commit comment for posterity. Ahh, also the
line "it needs the "ppc4xx: Generic architecture for xilinx ppc405"
patch from Ricardo" should go below the "---".
Also, s/minimodul/minimodule/ unless it really *is* spelled w/o the "e".
While we are critiquing the English, sentences start with capital
letters and end with periods, as in "This patch adds support for the
avnet fx12 minimodule."
WRT the subject line, the <v2> should go *inside* the [PATCH v2] so it
doesn't get included in the git repository comment.
> Signed-off-by: schardt <schardt@team-ctech.de>
> Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@uam.es>
> ---
Put your remarks here.
> MAINTAINERS | 4 +
> MAKEALL | 1 +
> Makefile | 18 +++++
> board/avnet/fx12mm/.gitignore | 1 +
> board/avnet/fx12mm/Makefile | 27 +++++++
> board/avnet/fx12mm/config.mk | 26 +++++++
> board/avnet/fx12mm/fx12mm.c | 52 +++++++++++++
> board/avnet/fx12mm/init.S | 32 ++++++++
> board/avnet/fx12mm/u-boot.lds | 149 ++++++++++++++++++++++++++++++++++++++
> board/avnet/fx12mm/xparameters.h | 51 +++++++++++++
> include/configs/fx12mm.h | 72 ++++++++++++++++++
[snip]
The bike shed is blue today.
Thanks,
gvb
next prev parent reply other threads:[~2008-10-22 12:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-22 9:25 [U-Boot] [PATCH] ppc4xx: New board avnet fx12 minimodule <v2> Georg Schardt
2008-10-22 9:34 ` Stefan Roese
2008-10-22 12:01 ` Jerry Van Baren [this message]
2008-10-22 12:36 ` Georg Schardt
2008-10-22 12:56 ` Jerry Van Baren
2008-10-24 11:01 ` Stefan Roese
2008-10-24 11:05 ` Georg Schardt
2008-10-24 11:18 ` Stefan Roese
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48FF1622.9050905@ge.com \
--to=gerald.vanbaren@ge.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox