public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Timur Tabi <timur@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] i2c_reg_read() on 8xx
Date: Wed, 22 Oct 2008 14:36:47 -0500	[thread overview]
Message-ID: <48FF80CF.3070209@freescale.com> (raw)

Wolfgang,

Mike Frysinger helped me resolve the problem with i2c_reg_read() on Blackfin, so
I'll be posting a new patch soon.  However, I noticed that 8xx has a problem, too:

uchar
i2c_reg_read(uchar i2c_addr, uchar reg)
{
        uchar buf;

        i2c_init(CONFIG_SYS_I2C_SPEED, CONFIG_SYS_I2C_SLAVE);

        i2c_read(i2c_addr, reg, 1, &buf, 1);

        return (buf);
}

Is the call to i2c_init() necessary on 8xx boards?  Shouldn't I2C have already
been initialized?

-- 
Timur Tabi
Linux kernel developer at Freescale

             reply	other threads:[~2008-10-22 19:36 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-22 19:36 Timur Tabi [this message]
     [not found] <48FF7F40.1010205@freescale.com>
2008-10-22 20:19 ` [U-Boot] i2c_reg_read() on 8xx Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48FF80CF.3070209@freescale.com \
    --to=timur@freescale.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox