From: Jerry Van Baren <gvb.uboot@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] fdt_resize(): ensure minimum padding
Date: Tue, 28 Oct 2008 20:26:38 -0400 [thread overview]
Message-ID: <4907ADBE.9000509@gmail.com> (raw)
In-Reply-To: <1225178812-22435-1-git-send-email-jacmet@sunsite.dk>
Peter Korsgaard wrote:
> fdt_add_mem_rsv() requires space for a struct fdt_reserve_entry
> (16 bytes), so make sure that fdt_resize at least adds that much
> padding, no matter what the location or size of the fdt is.
>
> Signed-off-by: Peter Korsgaard <jacmet@sunsite.dk>
> Acked-by: Andy Fleming <afleming@freescale.com>
> ---
> common/fdt_support.c | 7 +++++--
> 1 files changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/common/fdt_support.c b/common/fdt_support.c
> index 8ceeb0f..138334e 100644
> --- a/common/fdt_support.c
> +++ b/common/fdt_support.c
> @@ -575,9 +575,12 @@ int fdt_resize(void *blob)
> }
> }
>
> - /* Calculate the actual size of the fdt */
> + /*
> + * Calculate the actual size of the fdt
> + * plus the size needed for fdt_add_mem_rsv
> + */
> actualsize = fdt_off_dt_strings(blob) +
> - fdt_size_dt_strings(blob);
> + fdt_size_dt_strings(blob) + sizeof(struct fdt_reserve_entry);
>
> /* Make it so the fdt ends on a page boundary */
> actualsize = ALIGN(actualsize, 0x1000);
Applied to the u-boot-fdt subrepo.
Thanks,
gvb
next prev parent reply other threads:[~2008-10-29 0:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-28 7:26 [U-Boot] [PATCH] fdt_resize(): ensure minimum padding Peter Korsgaard
2008-10-29 0:26 ` Jerry Van Baren [this message]
-- strict thread matches above, loose matches on Subject: below --
2008-10-27 21:47 Peter Korsgaard
2008-10-27 22:20 ` Jerry Van Baren
2008-10-28 7:26 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4907ADBE.9000509@gmail.com \
--to=gvb.uboot@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox