From: Ilya Yanok <yanok@emcraft.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH/RFC] Some speed improvements to U-Boot JFFS2 code
Date: Sun, 02 Nov 2008 22:08:27 +0300 [thread overview]
Message-ID: <490DFAAB.2080105@emcraft.com> (raw)
In-Reply-To: <20081102160205.C0BB5832E40A@gemini.denx.de>
Hello Wolfgang,
Wolfgang Denk wrote:
>> Sounds good. That is what we were expecting.
>>
>
> If you submit a patch, then please add such comments *below* the "---"
> line.
>
That wasn't a patch submission actually... I've just wanted Michael to
test if this patch helps with his problem. I'll post the full updated
patch series soon.
>> diff --git a/common/cmd_jffs2.c b/common/cmd_jffs2.c
>> index e7f07bf..2fc0b7d 100644
>> --- a/common/cmd_jffs2.c
>> +++ b/common/cmd_jffs2.c
>> @@ -344,7 +344,9 @@ static int part_validate_nor(struct mtdids *id,
>> struct part_info *part)
>>
>> flash = &flash_info[id->num];
>>
>> - part->sector_size = 0;
>> + /* size of last sector */
>> + part->sector_size = flash->size -
>> + (flash->start[flash->sector_count-1] - flash->start[0]);
>>
>> offset_aligned = 0;
>> for (i = 0; i < flash->sector_count; i++) {
>> @@ -360,6 +362,7 @@ static int part_validate_nor(struct mtdids *id,
>> struct part_info *part)
>>
> ^^^^^^^^^^^^^^^^^^^^^^^^^^
>
> Patch is correcpted because your mailer wrapped long lines.
>
> Please fix your mailer setup and resubmit.
>
That's my fault... Usually I send patches with git-send-email... As I
said before I'll post correct patches in a short time.
Regards, Ilya.
next prev parent reply other threads:[~2008-11-02 19:08 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-13 5:53 [U-Boot] [PATCH/RFC] Some speed improvements to U-Boot JFFS2 code Ilya Yanok
2008-10-13 5:53 ` [U-Boot] [PATCH] jffs2: add sector_size field to part_info structure Ilya Yanok
2008-10-13 8:17 ` Wolfgang Denk
2008-10-15 12:35 ` Ilya Yanok
2008-10-13 5:53 ` [U-Boot] [PATCH] jffs2: rewrite jffs2 scanning code based on Linux one Ilya Yanok
2008-10-13 5:53 ` [U-Boot] [PATCH] jffs2: summary support Ilya Yanok
2008-10-13 5:53 ` [U-Boot] [PATCH] jffs2: fix searching for latest version in jffs2_1pass_list_inodes() Ilya Yanok
2008-10-13 5:53 ` [U-Boot] [PATCH] jffs2: add buffer to cache flash accesses Ilya Yanok
2008-10-13 5:53 ` [U-Boot] [PATCH] jffs2: cache data_crc results Ilya Yanok
2008-10-14 9:25 ` Michael Lawnick
2008-10-13 8:14 ` [U-Boot] [PATCH/RFC] Some speed improvements to U-Boot JFFS2 code Wolfgang Denk
2008-10-15 12:44 ` Ilya Yanok
2008-10-16 12:36 ` Michael Lawnick
2008-11-01 1:00 ` Ilya Yanok
2008-11-02 16:02 ` Wolfgang Denk
2008-11-02 19:08 ` Ilya Yanok [this message]
2008-11-04 11:14 ` Michael Lawnick
2008-11-04 12:31 ` Michael Lawnick
2008-11-04 13:14 ` Joakim Tjernlund
2008-11-05 7:59 ` Michael Lawnick
2008-11-11 6:49 ` Alexey Neyman
2008-11-11 8:19 ` Joakim Tjernlund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=490DFAAB.2080105@emcraft.com \
--to=yanok@emcraft.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox