public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Jens Gehrlein <sew_s@tqs.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] CFI: flash_write_cfiword() slow
Date: Mon, 03 Nov 2008 12:15:47 +0100	[thread overview]
Message-ID: <490EDD63.1010403@tqs.de> (raw)

Hi list,

having a look at function 
drivers/mtd/cfi_flash.c::flash_write_cfiword(), I found that 
find_sector() is called twice when having AMD standard, extended or 
legacy device. The first time, when writing the command. The second 
time, when calling flash_full_status_check().

Maybe this is the reason, why this programming mode is so slow.
find_sector() loops through the sector table from the last sector to
the current sector. And the more sectors the device has, the slower
the algorithm becomes. And this process for every sector to be 
programmed. And yes, there are still devices around without (standard) 
write buffer, e.g. the Samsung K8P2815UQB.

Before spending time to create a patch, I would like to read your 
opinion about this proposal/question:
Would it be sufficient to just add a flag, that indicates, that the 
sector number has already been calculated for AMD flashes or would it be 
better to pass parameters to flash_full_status_check() dependent on the 
command set?
Other proposals?
Do you see any unwanted side effects?

-- 
Kind regards,
Jens

             reply	other threads:[~2008-11-03 11:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-03 11:15 Jens Gehrlein [this message]
2008-11-03 20:10 ` [U-Boot] CFI: flash_write_cfiword() slow Wolfgang Denk
2008-12-12 16:34   ` Jens Gehrlein

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=490EDD63.1010403@tqs.de \
    --to=sew_s@tqs.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox