From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Lawnick Date: Tue, 04 Nov 2008 13:31:45 +0100 Subject: [U-Boot] [PATCH/RFC] Some speed improvements to U-Boot JFFS2 code In-Reply-To: <49102E92.7010909@gmx.de> References: <1223877234-720-1-git-send-email-yanok@emcraft.com> <20081013081442.665DB85DAB1C@gemini.denx.de> <48F5E5CB.3070303@emcraft.com> <48F73540.3020504@gmx.de> <490BAA2A.6020806@emcraft.com> <49102E92.7010909@gmx.de> Message-ID: <491040B1.7080407@gmx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Michael Lawnick said the following: ... > - output of access rights is still corrupted, e.g.: > d????-??-? 0 Tue Oct 21 11:08:17 2008 10 > -????-??-? 262144 Thu Jan 01 00:00:33 1970 u-boot.bin > d????-??-? 0 Tue Oct 21 11:08:32 2008 1 > d????-??-? 0 Tue Oct 21 11:00:58 2008 2 ... Ok, fixed this in my code: in jffs2_1pass.c @@ mkmodestr(unsigned long mode, char *str) you'll find declaration static const char *l = "xwr"; Although this is per se correct, it is not needed in context and screws up 'ls' in my case: Our u-boot is not placed in flash were it is located to on compilation time. static const char * points into flash space at some not properly initialized flash space. After modifying to char *l = "xwr"; output of access rights is fine now: drwxr-xr-x 0 Tue Oct 21 11:08:17 2008 10 -rwxr-xr-x 262144 Thu Jan 01 00:00:33 1970 u-boot.bin drwxr-xr-x 0 Tue Oct 21 11:08:32 2008 1 drwxr-xr-x 0 Tue Oct 21 11:00:58 2008 2 (Still directories are listed multiple times) Could we modify this declaration to my non-static version in the trunk? -- Michael Lawnick Software Design Engineer Lise-Meitner-Str. 7/1 89081 Ulm Tel: +49 731 9533 2066 Michael.Lawnick.ext at nsn.com http://www.nokiasiemensnetworks.com/global/ Think before you print