From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dirk Behme <dirk.behme@googlemail.com>
Date: Mon, 10 Nov 2008 20:20:56 +0100
Subject: [U-Boot] [PATCH 04/13 v5] ARM: OMAP3: Add lowlevel init
 and	sys_info common files
In-Reply-To: <20081109135131.GA25307@game.jcrosoft.org>
References: <490df313.1358560a.73b4.222e@mx.google.com>
	<490df32e.0c07560a.16d0.26b4@mx.google.com>
	<20081109135131.GA25307@game.jcrosoft.org>
Message-ID: <49188998.1030409@googlemail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Dear Jean-Christophe,

Jean-Christophe PLAGNIOL-VILLARD wrote:

>>+/*********************************************************************
>>+ *  display_board_info() - print banner with board info.
>>+ *********************************************************************/
>>+void display_board_info(u32 btype)
>>+{
>>+	char *bootmode[] = {
>>+		"NOR",
>>+		"ONENAND",
>>+		"NAND",
>>+		"P2a",
>>+		"NOR",
>>+		"NOR",
>>+		"P2a",
>>+		"P2b",
>>+	};
>>+	u32 brev = get_board_rev();
> 
> 
> 
>>+	char db_ver[] = "0.0";	/* board type */
>>+	char mem_sdr[] = "mSDR";	/* memory type */
>>+	char mem_ddr[] = "LPDDR";
>>+	char t_tst[] = "TST";	/* security level */
>>+	char t_emu[] = "EMU";
>>+	char t_hs[] = "HS";
>>+	char t_gp[] = "GP";
>>+	char unk[] = "?";
> 
> is it not better to have it as macro?

Would be quite nice if you could send an example to get an better 
understanding how you like to have this macro look like.

Many thanks and best regards

Dirk