[U-Boot] [PATCH] avr32/bootm: remove unused variable 'ret'

[U-Boot] [PATCH] avr32/bootm: remove unused variable 'ret'

[Jean-Christophe PLAGNIOL-VILLARD]

Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>

diff --git a/lib_avr32/bootm.c b/lib_avr32/bootm.c
index 556e3ea..03ab8d1 100644
--- a/lib_avr32/bootm.c
+++ b/lib_avr32/bootm.c
@@ -176,7 +176,6 @@ int do_bootm_linux(int flag, int argc, char *argv[], bootm_headers_t *images)
 	void	(*theKernel)(int magic, void *tagtable);
 	struct	tag *params, *params_start;
 	char	*commandline = getenv("bootargs");
-	int	ret;
 
 	if ((flag != 0) && (flag != BOOTM_STATE_OS_GO))
 		return 1;
-- 
1.5.6.5

[U-Boot] [PATCH] avr32/cmd_bdinfo: fix printf() format warnings

[Jean-Christophe PLAGNIOL-VILLARD]

Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>

diff --git a/common/cmd_bdinfo.c b/common/cmd_bdinfo.c
index 6675241..087eda7 100644
--- a/common/cmd_bdinfo.c
+++ b/common/cmd_bdinfo.c
@@ -378,7 +378,7 @@ int do_bdinfo ( cmd_tbl_t *cmdtp, int flag, int argc, char *argv[])
 	}
 	puts ("\nip_addr     = ");
 	print_IPaddr (bd->bi_ip_addr);
-	printf ("\nbaudrate    = %d bps\n", bd->bi_baudrate);
+	printf ("\nbaudrate    = %ld bps\n", bd->bi_baudrate);
 
 	return 0;
 }
-- 
1.5.6.5

[U-Boot] [PATCH] avr32/cmd_bdinfo: fix printf() format warnings

[Dirk Behme]

Jean-Christophe PLAGNIOL-VILLARD wrote:
> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> 
> diff --git a/common/cmd_bdinfo.c b/common/cmd_bdinfo.c
> index 6675241..087eda7 100644
> --- a/common/cmd_bdinfo.c
> +++ b/common/cmd_bdinfo.c

Subject mentions avr32/cmd_bdinfo while you touch common/cmd_bdinfo.c? 
Typo?

Dirk

> @@ -378,7 +378,7 @@ int do_bdinfo ( cmd_tbl_t *cmdtp, int flag, int argc, char *argv[])
>  	}
>  	puts ("\nip_addr     = ");
>  	print_IPaddr (bd->bi_ip_addr);
> -	printf ("\nbaudrate    = %d bps\n", bd->bi_baudrate);
> +	printf ("\nbaudrate    = %ld bps\n", bd->bi_baudrate);
>  
>  	return 0;
>  }

[U-Boot] [PATCH] avr32/cmd_bdinfo: fix printf() format warnings

[Jean-Christophe PLAGNIOL-VILLARD]

On 16:11 Tue 11 Nov     , Dirk Behme wrote:
> Jean-Christophe PLAGNIOL-VILLARD wrote:
>> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
>>
>> diff --git a/common/cmd_bdinfo.c b/common/cmd_bdinfo.c
>> index 6675241..087eda7 100644
>> --- a/common/cmd_bdinfo.c
>> +++ b/common/cmd_bdinfo.c
>
> Subject mentions avr32/cmd_bdinfo while you touch common/cmd_bdinfo.c?  
> Typo?
no the common/cmd_bdinfo regroup all arch I specify which one I've test and
fix

Best Regards,
J.

[U-Boot] [PATCH] avr32/cmd_bdinfo: fix printf() format warnings

[Wolfgang Denk]

Dear Jean-Christophe PLAGNIOL-VILLARD,

In message <20081111154936.GR25307@game.jcrosoft.org> you wrote:
> On 16:11 Tue 11 Nov     , Dirk Behme wrote:
> > Jean-Christophe PLAGNIOL-VILLARD wrote:
> >> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> >>
> >> diff --git a/common/cmd_bdinfo.c b/common/cmd_bdinfo.c
> >> index 6675241..087eda7 100644
> >> --- a/common/cmd_bdinfo.c
> >> +++ b/common/cmd_bdinfo.c
> >
> > Subject mentions avr32/cmd_bdinfo while you touch common/cmd_bdinfo.c?  
> > Typo?
> no the common/cmd_bdinfo regroup all arch I specify which one I've test and
> fix

I cannot make heads or tails from this comment.

Fact is that subject and code do not agree.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
No one can guarantee the actions of another.
	-- Spock, "Day of the Dove", stardate unknown

[U-Boot] [PATCH] avr32/bootm: remove unused variable 'ret'

[Haavard Skinnemoen]

Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com> wrote:
> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>

Acked-by: Haavard Skinnemoen <haavard.skinnemoen@atmel.com>

I'm a bit out of sync at the moment. Wolfgang, can you apply it
directly?

> diff --git a/lib_avr32/bootm.c b/lib_avr32/bootm.c
> index 556e3ea..03ab8d1 100644
> --- a/lib_avr32/bootm.c
> +++ b/lib_avr32/bootm.c
> @@ -176,7 +176,6 @@ int do_bootm_linux(int flag, int argc, char *argv[], bootm_headers_t *images)
>  	void	(*theKernel)(int magic, void *tagtable);
>  	struct	tag *params, *params_start;
>  	char	*commandline = getenv("bootargs");
> -	int	ret;
>  
>  	if ((flag != 0) && (flag != BOOTM_STATE_OS_GO))
>  		return 1;

[U-Boot] [PATCH] avr32/bootm: remove unused variable 'ret'

[Wolfgang Denk]

Dear Haavard Skinnemoen,

In message <20081113090806.74d87f70@hskinnemo-gx745.norway.atmel.com> you wrote:
> Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com> wrote:
> > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> 
> Acked-by: Haavard Skinnemoen <haavard.skinnemoen@atmel.com>
> 
> I'm a bit out of sync at the moment. Wolfgang, can you apply it
> directly?

Sure, done.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"That unit is a woman."
"A mass of conflicting impulses."
	-- Spock and Nomad, "The Changeling", stardate 3541.9

[U-Boot] [PATCH] avr32/bootm: remove unused variable 'ret'

[Wolfgang Denk]

Dear Jean-Christophe PLAGNIOL-VILLARD,

In message <1226380140-4323-1-git-send-email-plagnioj@jcrosoft.com> you wrote:
> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> 
> diff --git a/lib_avr32/bootm.c b/lib_avr32/bootm.c
> index 556e3ea..03ab8d1 100644
> --- a/lib_avr32/bootm.c
> +++ b/lib_avr32/bootm.c

Applied, thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
f u cn rd ths, itn tyg h myxbl cd.