From: Scott Wood <scottwood@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] mpc83xx: New board support SIMPC8313
Date: Wed, 12 Nov 2008 15:43:03 -0600 [thread overview]
Message-ID: <491B4DE7.7040302@freescale.com> (raw)
In-Reply-To: <872627.5479.qm@web83508.mail.sp1.yahoo.com>
Ron Madrid wrote:
>>> + *((u32 *)(CFG_IMMR + addr)) = data;
>> use the out_be32 i/o memory accessor and friends please (here and
>> elsewhere in the patch).
>>
>
> I am trying to resolve this last issue with your review and replacing
> all of the i/o memory accesses with in/out_be* has caused my
> code to inflate by about 200 bytes, and now I'm over the 4K limit
> by about 160 bytes for the 8313 bootstrap. Without trying to
> squeeze my code is there anything that could be done to shrink
> my code?
Use raw accessors and make sure that explicit barriers are used where
needed.
-Scott
next prev parent reply other threads:[~2008-11-12 21:43 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-12 21:33 [U-Boot] [PATCH] mpc83xx: New board support SIMPC8313 Ron Madrid
2008-11-12 21:43 ` Scott Wood [this message]
-- strict thread matches above, loose matches on Subject: below --
2008-11-13 18:42 Ron Madrid
2008-11-13 18:45 ` Scott Wood
2008-11-11 22:26 Ron Madrid
2008-11-11 23:36 ` Kim Phillips
2008-11-10 22:18 Ron Madrid
2008-11-10 22:23 ` Wolfgang Denk
2008-11-10 21:45 Ron Madrid
2008-11-10 22:06 ` Kim Phillips
2008-11-05 0:37 Ron Madrid
2008-11-07 2:39 ` Kim Phillips
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=491B4DE7.7040302@freescale.com \
--to=scottwood@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox