From mboxrd@z Thu Jan 1 00:00:00 1970 From: Scott Wood Date: Wed, 12 Nov 2008 15:43:03 -0600 Subject: [U-Boot] [PATCH] mpc83xx: New board support SIMPC8313 In-Reply-To: <872627.5479.qm@web83508.mail.sp1.yahoo.com> References: <872627.5479.qm@web83508.mail.sp1.yahoo.com> Message-ID: <491B4DE7.7040302@freescale.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Ron Madrid wrote: >>> + *((u32 *)(CFG_IMMR + addr)) = data; >> use the out_be32 i/o memory accessor and friends please (here and >> elsewhere in the patch). >> > > I am trying to resolve this last issue with your review and replacing > all of the i/o memory accesses with in/out_be* has caused my > code to inflate by about 200 bytes, and now I'm over the 4K limit > by about 160 bytes for the 8313 bootstrap. Without trying to > squeeze my code is there anything that could be done to shrink > my code? Use raw accessors and make sure that explicit barriers are used where needed. -Scott