public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Ben Warren <biggerbadderben@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/6] jffs2: add sector_size field to part_info structure
Date: Thu, 13 Nov 2008 10:16:22 -0800	[thread overview]
Message-ID: <491C6EF6.8090702@gmail.com> (raw)
In-Reply-To: <20081113180121.GC25695@game.jcrosoft.org>

Jean-Christophe PLAGNIOL-VILLARD wrote:
> On 19:49 Thu 13 Nov     , Ilya Yanok wrote:
>   
>> This patch adds sector_size field to part_info structure (used
>> by new JFFS2 code).
>>
>> Signed-off-by: Ilya Yanok <yanok@emcraft.com>
>> ---
>>  common/cmd_jffs2.c          |   20 +++++++++++++++++---
>>  include/jffs2/load_kernel.h |    1 +
>>  2 files changed, 18 insertions(+), 3 deletions(-)
>>
>> diff --git a/common/cmd_jffs2.c b/common/cmd_jffs2.c
>> index 791a572..e2bf198 100644
>> --- a/common/cmd_jffs2.c
>> +++ b/common/cmd_jffs2.c
>> @@ -339,11 +339,15 @@ static int part_validate_nor(struct mtdids *id, struct part_info *part)
>>  	extern flash_info_t flash_info[];
>>  	flash_info_t *flash;
>>  	int offset_aligned;
>> -	u32 end_offset;
>> +	u32 end_offset, sector_size = 0;
>>     
> please spit in two lines
>   
Why do you waste peoples' time with this pedantic nit-picking?  There's 
absolutely nothing wrong with having them both on the same line, 
especially if it's the only thing you can object to in the patch.

regards,
Ben

  reply	other threads:[~2008-11-13 18:16 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-13 16:49 [U-Boot] [RFC PATCH 0/6] Some speed improvements to U-Boot JFFS2 code (updated) Ilya Yanok
2008-11-13 16:49 ` [U-Boot] [PATCH 1/6] jffs2: fix searching for latest version in jffs2_1pass_list_inodes() Ilya Yanok
2008-12-09 22:38   ` Wolfgang Denk
2008-11-13 16:49 ` [U-Boot] [PATCH 2/6] jffs2: add sector_size field to part_info structure Ilya Yanok
2008-11-13 18:01   ` Jean-Christophe PLAGNIOL-VILLARD
2008-11-13 18:16     ` Ben Warren [this message]
2008-12-09 22:39   ` Wolfgang Denk
2008-11-13 16:49 ` [U-Boot] [PATCH 3/6] jffs2: rewrite jffs2 scanning code based on Linux one Ilya Yanok
2008-11-13 18:06   ` Jean-Christophe PLAGNIOL-VILLARD
2008-11-20 14:31     ` Ilya Yanok
2008-12-09 22:39   ` Wolfgang Denk
2008-12-10 13:30   ` Stefan Roese
2008-12-11  2:49     ` Ilya Yanok
2008-12-11  2:51       ` [U-Boot] [PATCH] jffs2: include <linux/mtd/compat.h> instead of defining own min_t Ilya Yanok
2008-12-11  6:24         ` Stefan Roese
2008-12-16 16:14         ` Wolfgang Denk
2008-11-13 16:49 ` [U-Boot] [PATCH 4/6] jffs2: add buffer to cache flash accesses Ilya Yanok
2008-12-09 22:41   ` Wolfgang Denk
2008-11-13 16:49 ` [U-Boot] [PATCH 5/6] jffs2: summary support Ilya Yanok
2008-12-09 22:41   ` Wolfgang Denk
2008-11-13 16:49 ` [U-Boot] [PATCH 6/6] jffs2: cache data_crc results Ilya Yanok
2008-12-09 22:41   ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=491C6EF6.8090702@gmail.com \
    --to=biggerbadderben@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox