From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Warren Date: Thu, 13 Nov 2008 10:16:22 -0800 Subject: [U-Boot] [PATCH 2/6] jffs2: add sector_size field to part_info structure In-Reply-To: <20081113180121.GC25695@game.jcrosoft.org> References: <1226594976-6087-1-git-send-email-yanok@emcraft.com> <1226594976-6087-3-git-send-email-yanok@emcraft.com> <20081113180121.GC25695@game.jcrosoft.org> Message-ID: <491C6EF6.8090702@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Jean-Christophe PLAGNIOL-VILLARD wrote: > On 19:49 Thu 13 Nov , Ilya Yanok wrote: > >> This patch adds sector_size field to part_info structure (used >> by new JFFS2 code). >> >> Signed-off-by: Ilya Yanok >> --- >> common/cmd_jffs2.c | 20 +++++++++++++++++--- >> include/jffs2/load_kernel.h | 1 + >> 2 files changed, 18 insertions(+), 3 deletions(-) >> >> diff --git a/common/cmd_jffs2.c b/common/cmd_jffs2.c >> index 791a572..e2bf198 100644 >> --- a/common/cmd_jffs2.c >> +++ b/common/cmd_jffs2.c >> @@ -339,11 +339,15 @@ static int part_validate_nor(struct mtdids *id, struct part_info *part) >> extern flash_info_t flash_info[]; >> flash_info_t *flash; >> int offset_aligned; >> - u32 end_offset; >> + u32 end_offset, sector_size = 0; >> > please spit in two lines > Why do you waste peoples' time with this pedantic nit-picking? There's absolutely nothing wrong with having them both on the same line, especially if it's the only thing you can object to in the patch. regards, Ben