public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Nobuhiro Iwamatsu <iwamatsu.nobuhiro@renesas.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] sh: Update sh timer function
Date: Tue, 18 Nov 2008 10:37:56 +0900	[thread overview]
Message-ID: <49221C74.6040602@renesas.com> (raw)
In-Reply-To: <20081117121454.GC9160@game.jcrosoft.org>

Hi,

Jean-Christophe PLAGNIOL-VILLARD wrote:
> On 16:51 Mon 17 Nov     , Nobuhiro Iwamatsu wrote:
>> Change to write/readX fcuntion and fix timer bug.
>>
>> Signed-off-by: Nobuhiro Iwamatsu <iwamatsu@nigauri.org>
>> ---
>>  cpu/sh3/Makefile |    2 +-
>>  cpu/sh3/time.c   |  103 ------------------------------------------------------
>>  cpu/sh4/time.c   |   76 ++++++++++++++++++++++++++-------------
>>  3 files changed, 52 insertions(+), 129 deletions(-)
>>  delete mode 100644 cpu/sh3/time.c
>>
>> diff --git a/cpu/sh3/Makefile b/cpu/sh3/Makefile
>> index 587413d..e3e5777 100644
>> --- a/cpu/sh3/Makefile
>> +++ b/cpu/sh3/Makefile
>> @@ -32,7 +32,7 @@ include $(TOPDIR)/config.mk
>>  LIB	= $(obj)lib$(CPU).a
>>
>>  SOBJS	= start.o
>> -COBJS	= cpu.o interrupts.o watchdog.o time.o cache.o
>> +COBJS	= cpu.o interrupts.o watchdog.o cache.o ../sh4/time.o
> I'm not a fan of this
> 
> Maybe you could change the current storrage as this
> 
> cpu/sh
>     |- cpu/sh/time.c
>     here the common sh code
> cpu/sh/sh4/
>     sh4 specific
> cpu/sh/sh3/
>     sh3 specific

OK, you are right.

I think about directory constitution.
Thank you for commnet.

Best regards,
  Nobuhiro

  reply	other threads:[~2008-11-18  1:37 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-17  7:51 [U-Boot] [PATCH] sh: Update sh timer function Nobuhiro Iwamatsu
2008-11-17 12:14 ` Jean-Christophe PLAGNIOL-VILLARD
2008-11-18  1:37   ` Nobuhiro Iwamatsu [this message]
2008-12-09 23:07 ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49221C74.6040602@renesas.com \
    --to=iwamatsu.nobuhiro@renesas.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox