From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nobuhiro Iwamatsu Date: Tue, 18 Nov 2008 10:37:56 +0900 Subject: [U-Boot] [PATCH] sh: Update sh timer function In-Reply-To: <20081117121454.GC9160@game.jcrosoft.org> References: <4921227D.9070801@renesas.com> <20081117121454.GC9160@game.jcrosoft.org> Message-ID: <49221C74.6040602@renesas.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi, Jean-Christophe PLAGNIOL-VILLARD wrote: > On 16:51 Mon 17 Nov , Nobuhiro Iwamatsu wrote: >> Change to write/readX fcuntion and fix timer bug. >> >> Signed-off-by: Nobuhiro Iwamatsu >> --- >> cpu/sh3/Makefile | 2 +- >> cpu/sh3/time.c | 103 ------------------------------------------------------ >> cpu/sh4/time.c | 76 ++++++++++++++++++++++++++------------- >> 3 files changed, 52 insertions(+), 129 deletions(-) >> delete mode 100644 cpu/sh3/time.c >> >> diff --git a/cpu/sh3/Makefile b/cpu/sh3/Makefile >> index 587413d..e3e5777 100644 >> --- a/cpu/sh3/Makefile >> +++ b/cpu/sh3/Makefile >> @@ -32,7 +32,7 @@ include $(TOPDIR)/config.mk >> LIB = $(obj)lib$(CPU).a >> >> SOBJS = start.o >> -COBJS = cpu.o interrupts.o watchdog.o time.o cache.o >> +COBJS = cpu.o interrupts.o watchdog.o cache.o ../sh4/time.o > I'm not a fan of this > > Maybe you could change the current storrage as this > > cpu/sh > |- cpu/sh/time.c > here the common sh code > cpu/sh/sh4/ > sh4 specific > cpu/sh/sh3/ > sh3 specific OK, you are right. I think about directory constitution. Thank you for commnet. Best regards, Nobuhiro