From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shinya Kuribayashi Date: Tue, 18 Nov 2008 11:41:09 +0900 Subject: [U-Boot] [PATCH] MIPS: Add board_early_init_f() to init_sequence In-Reply-To: <200811171456.13382.sr@denx.de> References: <1226492282-27777-1-git-send-email-sr@denx.de> <491FC552.6060102@ruby.dti.ne.jp> <200811171456.13382.sr@denx.de> Message-ID: <49222B45.2070300@necel.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Stefan Roese wrote: >> This is ok. I don't know why people prefers alias, though :-) > > Just because we don't need the ugly #ifdef's by using weak aliases. It has > some drawbacks of course but in general the resulting source code > looks "cleaner". I was being vague. I prefers something like below, because I don't want to have a dummy & empty function just for the `alias'. int __attribute__((weak)) board_early_init_f(void) { return 0; } But that's not a big deal. Using weak function is ok, of course. Sorry for the noise. Thanks, -- Shinya Kuribayashi NEC Electronics