From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shinya Kuribayashi Date: Wed, 19 Nov 2008 00:00:47 +0900 Subject: [U-Boot] [PATCH] MIPS: Add board_early_init_f() to init_sequence In-Reply-To: <20081117141419.GF9160@game.jcrosoft.org> References: <1226492282-27777-1-git-send-email-sr@denx.de> <20081117141419.GF9160@game.jcrosoft.org> Message-ID: <4922D89F.5030708@ruby.dti.ne.jp> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Jean-Christophe PLAGNIOL-VILLARD wrote: > On 13:18 Wed 12 Nov , Stefan Roese wrote: >> diff --git a/lib_mips/board.c b/lib_mips/board.c >> index 77e1cc8..01dda69 100644 >> --- a/lib_mips/board.c >> +++ b/lib_mips/board.c >> @@ -70,6 +70,15 @@ static ulong mem_malloc_brk; >> */ >> unsigned long mips_io_port_base = -1; >> >> +int __board_early_init_f(void) >> +{ >> + /* >> + * Nothing to do in this dummy implementation >> + */ >> + return 0; >> +} > why not remove this and create a generic dummy function > > to reduce to code size impact +1. Such dummy function could be shared among all architectures. Thanks, Shinya