public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Richard Retanubun <RichardRetanubun@RuggedCom.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] common/cmd_ide.c: Corrected endian order printing for compact flash serial number.
Date: Wed, 19 Nov 2008 09:14:55 -0500	[thread overview]
Message-ID: <49241F5F.3090705@RuggedCom.com> (raw)
In-Reply-To: <49133F1F.1010403@RuggedCom.com>

Hi Wolfgang,

By no means is this a critical patch, I'm just a bit obsessive about tying up loose ends (or patches)
Is there a custodian I should ping for feedback on this patch, or are you it?

Thanks for your time

- Richard
 
Richard Retanubun wrote:

> Corrected endian order printing for compact flash serial number.
>
> Signed-off-by: Richard Retanubun <RichardRetanubun@RuggedCom.com>
> ---
>  common/cmd_ide.c |    7 ++++---
>  1 files changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/common/cmd_ide.c b/common/cmd_ide.c
> index 2564c2b..db05f76 100644
> --- a/common/cmd_ide.c
> +++ b/common/cmd_ide.c
> @@ -1166,15 +1166,16 @@ static void ide_ident (block_dev_desc_t *dev_desc)
>  	ident_cpy ((unsigned char*)dev_desc->product, iop->serial_no, sizeof(dev_desc->product));
>  #ifdef __LITTLE_ENDIAN
>  	/*
> -	 * firmware revision and model number have Big Endian Byte
> -	 * order in Word. Convert both to little endian.
> +	 * firmware revision, model, and serial number have Big Endian Byte
> +	 * order in Word. Convert all three to little endian.
>  	 *
>  	 * See CF+ and CompactFlash Specification Revision 2.0:
> -	 * 6.2.1.6: Identfy Drive, Table 39 for more details
> +	 * 6.2.1.6: Identify Drive, Table 39 for more details
>  	 */
>  
>  	strswab (dev_desc->revision);
>  	strswab (dev_desc->vendor);
> +	strswab (dev_desc->product);
>  #endif /* __LITTLE_ENDIAN */
>  
>  	if ((iop->config & 0x0080)==0x0080)

  reply	other threads:[~2008-11-19 14:14 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-06 19:01 [U-Boot] [PATCH] common/cmd_ide.c: Corrected endian order printing for compact flash serial number Richard Retanubun
2008-11-19 14:14 ` Richard Retanubun [this message]
2008-12-07  0:25 ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49241F5F.3090705@RuggedCom.com \
    --to=richardretanubun@ruggedcom.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox