From mboxrd@z Thu Jan 1 00:00:00 1970 From: Richard Retanubun Date: Wed, 19 Nov 2008 09:14:55 -0500 Subject: [U-Boot] [PATCH] common/cmd_ide.c: Corrected endian order printing for compact flash serial number. In-Reply-To: <49133F1F.1010403@RuggedCom.com> References: <49133F1F.1010403@RuggedCom.com> Message-ID: <49241F5F.3090705@RuggedCom.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Wolfgang, By no means is this a critical patch, I'm just a bit obsessive about tying up loose ends (or patches) Is there a custodian I should ping for feedback on this patch, or are you it? Thanks for your time - Richard Richard Retanubun wrote: > Corrected endian order printing for compact flash serial number. > > Signed-off-by: Richard Retanubun > --- > common/cmd_ide.c | 7 ++++--- > 1 files changed, 4 insertions(+), 3 deletions(-) > > diff --git a/common/cmd_ide.c b/common/cmd_ide.c > index 2564c2b..db05f76 100644 > --- a/common/cmd_ide.c > +++ b/common/cmd_ide.c > @@ -1166,15 +1166,16 @@ static void ide_ident (block_dev_desc_t *dev_desc) > ident_cpy ((unsigned char*)dev_desc->product, iop->serial_no, sizeof(dev_desc->product)); > #ifdef __LITTLE_ENDIAN > /* > - * firmware revision and model number have Big Endian Byte > - * order in Word. Convert both to little endian. > + * firmware revision, model, and serial number have Big Endian Byte > + * order in Word. Convert all three to little endian. > * > * See CF+ and CompactFlash Specification Revision 2.0: > - * 6.2.1.6: Identfy Drive, Table 39 for more details > + * 6.2.1.6: Identify Drive, Table 39 for more details > */ > > strswab (dev_desc->revision); > strswab (dev_desc->vendor); > + strswab (dev_desc->product); > #endif /* __LITTLE_ENDIAN */ > > if ((iop->config & 0x0080)==0x0080)