From: Steven A. Falco <sfalco@harris.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Bits reversed in ppc4xx.h
Date: Wed, 19 Nov 2008 11:03:49 -0500 [thread overview]
Message-ID: <492438E5.3050900@harris.com> (raw)
The bits in ppc440.h for the SDR0_DDRCFG register are incorrect. The
register is numbered in big-endian mode, so for example, the LT2 bit
(bit 23) should be represented as 0x00000100 rather than 0x01000000.
Signed-off-by: Steven A. Falco <sfalco@harris.com>
---
diff --git a/include/ppc440.h b/include/ppc440.h
index c581f1b..520b0d9 100644
--- a/include/ppc440.h
+++ b/include/ppc440.h
@@ -174,13 +174,13 @@
#define sdr_ddrdl 0x00e0
#else
#define sdr_cfg 0x00e0
-#define SDR_CFG_LT2_MASK 0x01000000 /* Leakage test 2*/
-#define SDR_CFG_64_32BITS_MASK 0x01000000 /* Switch DDR 64 bits or 32 bits */
+#define SDR_CFG_LT2_MASK 0x00000100 /* Leakage test 2*/
+#define SDR_CFG_64_32BITS_MASK 0x00000080 /* Switch DDR 64 bits or 32 bits */
#define SDR_CFG_32BITS 0x00000000 /* 32 bits */
-#define SDR_CFG_64BITS 0x01000000 /* 64 bits */
-#define SDR_CFG_MC_V2518_MASK 0x02000000 /* Low VDD2518 (2.5 or 1.8V) */
+#define SDR_CFG_64BITS 0x00000080 /* 64 bits */
+#define SDR_CFG_MC_V2518_MASK 0x00000040 /* Low VDD2518 (2.5 or 1.8V) */
#define SDR_CFG_MC_V25 0x00000000 /* 2.5 V */
-#define SDR_CFG_MC_V18 0x02000000 /* 1.8 V */
+#define SDR_CFG_MC_V18 0x00000040 /* 1.8 V */
#endif /* !defined(CONFIG_440EPX) && !defined(CONFIG_440GRX) */
#define sdr_ebc 0x0100
#define sdr_uart0 0x0120 /* UART0 Config */
--
1.6.0.2
next reply other threads:[~2008-11-19 16:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-19 16:03 Steven A. Falco [this message]
2008-11-20 9:56 ` [U-Boot] [PATCH] Bits reversed in ppc4xx.h Stefan Roese
2008-11-20 15:31 ` [U-Boot] [PATCH] Delete unused definitions for SDR0_DDRCFG from ppc4xx.h Steven A. Falco
2008-11-20 18:07 ` Stefan Roese
2008-11-20 19:37 ` [U-Boot] [PATCH v2] " Steven A. Falco
2008-11-21 10:05 ` Stefan Roese
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=492438E5.3050900@harris.com \
--to=sfalco@harris.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox