[U-Boot] [RFC PATCH] USB style patch

michael
2008-11-26T13:18:59Z

Wolfgang Denk wrote:
> Dear michael,
>
> In message <492D31AC.2070006@gandalf.sssup.it> you wrote:
>
>>>> - printf(" NOTE: this command is obsolete and will be phased out\n");
>>>> - printf(" please use 'usb storage' for USB storage devices information\n\n");
>>>> + printf(" NOTE: this command is obsolete and will be"
>>>> + " phased out\n");
>>>> + printf(" please use 'usb storage' for USB storage devices"
>>>> + " information\n\n");
>>>>
>>>>
>>> I believe it is good to keep line lengths below 80 characters in
>>> general, but code should not become less readable by this.
>>> In case of printf lines, it becomes more difficult to 'grep' for the
>>> strings printed in the terminal to find them back in the code.
>>> So, I am very curious about the point of view Wolfgang about this
>>> rule. (How strict does this rule need to be applied?)
>>>
>>>
>> I prefer to break the line but I wait for Walfgang answer.
>>
>
> I tend to go with Remy here, but tyher eis another (even better)
> option: do what the warning says, and remove the obsolete code.
>
>
At the end, can I break to 80 char and "..remove the obsolete code"?
It is nessary a grep with the full message? There are a lot of situation
when the grep is impossible.

> Best regards,
>
> Wolfgang Denk
>
>
Regards Michael