From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Warren Date: Tue, 02 Dec 2008 16:43:32 -0800 Subject: [U-Boot] [PATCH] net/net.c: correct timeout function In-Reply-To: <20081203003111.GB2012@buzzloop.caiaq.de> References: <20081128162529.GA14044@buzzloop.caiaq.de> <20081203003111.GB2012@buzzloop.caiaq.de> Message-ID: <4935D634.8060003@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Daniel, Daniel Mack wrote: > On Fri, Nov 28, 2008 at 05:25:29PM +0100, Daniel Mack wrote: > >> the net/net.c implemenation of timeouts assumes that get_timer() returns >> values in milliseconds. As this is true for most platforms, it does not >> apply to PXA3x where the OSCR register increments with more than 3MHz. >> >> The following patch fixes the problem by calculation with the >> CONFIG_SYS_HZ variable. >> > > [...] > > Just curious - was this patch taken? Same question for the ones sent in > mails labeled > > [PATCH] ne2000: take MAC address from config if available (+follow-ups) Sorry, I've been bogged down with other stuff. Some things are missing from your patches, which can mainly be fixed by using 'git format-patch -C': 1. No signed-off-by 2. No diffstat 3. Place text that shouldn't be in the commit message below the '---' line If you take care of this easy stuff and resubmit I'll take a hard look at the content in the next couple of days. Please understand that the merge window is currently closed, so your code won't make it into the mainline U-boot until January sometime, although it will go in the net tree as soon as it's compliant. regards, Ben