From: Ben Warren <biggerbadderben@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] net: Fix TftpStart() ip:filename bug
Date: Thu, 04 Dec 2008 23:08:54 -0800 [thread overview]
Message-ID: <4938D386.4080904@gmail.com> (raw)
In-Reply-To: <1228170578-22689-1-git-send-email-ptyser@xes-inc.com>
Hi Peter,
Peter Tyser wrote:
> The TftpStart() function modifies the 'BootFile'
> string when 'BootFile' contains both an IP address
> and filename (eg 1.2.3.4:/path/file). This causes
> subsequent calls to TftpStart to incorrectly parse
> the TFTP filename and server IP address to use.
> For example:
>
> => tftp 0x100000 10.52.0.62:/home/ptyser/non_existant
> Speed: 100, half duplex
> Using eTSEC1 device
> TFTP from server 10.52.0.62; our IP address is 10.52.253.79
> ^^^^^^^^^^ CORRECT
> Filename '/home/ptyser/non_existant'.
> ^^^^^^^^^^^^^^^^^^^^^^^^^ CORRECT
> Load address: 0x100000
> Loading: *
> TFTP error: 'File not found' (1)
> Starting again
>
> eTSEC2: No link.
> Speed: 100, half duplex
> Using eTSEC1 device
> TFTP from server 10.52.0.33; our IP address is 10.52.253.79
> ^^^^^^^^^^ WRONG
> Filename '10.52.0.62'.
> ^^^^^^^^^^ WRONG
> Load address: 0x100000
> Loading: *
> TFTP error: 'File not found' (1)
> Starting again
>
> TftpStart() was modified to not modify the 'BootFile' string.
>
> Signed-off-by: Peter Tyser <ptyser@xes-inc.com>
> ---
Applied to net repo.
thanks,
Ben
prev parent reply other threads:[~2008-12-05 7:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-01 22:29 [U-Boot] [PATCH v2] net: Fix TftpStart() ip:filename bug Peter Tyser
2008-12-05 7:08 ` Ben Warren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4938D386.4080904@gmail.com \
--to=biggerbadderben@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox