From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ben Warren <biggerbadderben@gmail.com>
Date: Thu, 04 Dec 2008 23:08:54 -0800
Subject: [U-Boot] [PATCH v2] net: Fix TftpStart() ip:filename bug
In-Reply-To: <1228170578-22689-1-git-send-email-ptyser@xes-inc.com>
References: <1228170578-22689-1-git-send-email-ptyser@xes-inc.com>
Message-ID: <4938D386.4080904@gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Peter,

Peter Tyser wrote:
> The TftpStart() function modifies the 'BootFile'
> string when 'BootFile' contains both an IP address
> and filename (eg 1.2.3.4:/path/file). This causes
> subsequent calls to TftpStart to incorrectly parse
> the TFTP filename and server IP address to use.
> For example:
>
> => tftp 0x100000 10.52.0.62:/home/ptyser/non_existant
> Speed: 100, half duplex
> Using eTSEC1 device
> TFTP from server 10.52.0.62; our IP address is 10.52.253.79
>                  ^^^^^^^^^^ CORRECT
> Filename '/home/ptyser/non_existant'.
>           ^^^^^^^^^^^^^^^^^^^^^^^^^ CORRECT
> Load address: 0x100000
> Loading: *
> TFTP error: 'File not found' (1)
> Starting again
>
> eTSEC2: No link.
> Speed: 100, half duplex
> Using eTSEC1 device
> TFTP from server 10.52.0.33; our IP address is 10.52.253.79
>                  ^^^^^^^^^^ WRONG
> Filename '10.52.0.62'.
>           ^^^^^^^^^^ WRONG
> Load address: 0x100000
> Loading: *
> TFTP error: 'File not found' (1)
> Starting again
>
> TftpStart() was modified to not modify the 'BootFile' string.
>
> Signed-off-by: Peter Tyser <ptyser@xes-inc.com>
> ---

Applied to net repo.

thanks,
Ben