From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Warren Date: Thu, 04 Dec 2008 23:09:53 -0800 Subject: [U-Boot] [PATCH] net: tsec: Fix Marvell 88E1121R phy init In-Reply-To: <2acbd3e40812021346u304f2807k4d28b00197cf554a@mail.gmail.com> References: <1228210264-8370-1-git-send-email-agust@denx.de> <2acbd3e40812021346u304f2807k4d28b00197cf554a@mail.gmail.com> Message-ID: <4938D3C1.6030201@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Anatolij & Andy, Andy Fleming wrote: > On Tue, Dec 2, 2008 at 3:31 AM, Anatolij Gustschin wrote: > >> This patch tries to ensure that phy interrupt pin >> won't be asserted after booting. We experienced >> following issues with current 88E1121R phy init: >> >> Marvell 88E1121R phy can be hardware-configured >> to share MDC/MDIO and interrupt pins for both ports >> P0 and P1 (e.g. as configured on socrates board). >> Port 0 interrupt pin will be shared by both ports >> in such configuration. After booting Linux and >> configuring eth0 interface, port 0 phy interrupts >> are enabled. After rebooting without proper eth0 >> interface shutdown port 0 phy interrupts remain >> enabled so any change on port 0 (link status, etc.) >> cause assertion of the interrupt. Now booting Linux >> and configuring eth1 interface will cause permanent >> phy interrupt storm as the registered phy 1 interrupt >> handler doesn't acknowledge phy 0 interrupts. This >> of course should be fixed in Linux driver too. >> > > Agreed, and... > > >> Signed-off-by: Anatolij Gustschin >> > > Acked-by: Andy Fleming > Applied to net repo. thanks, Ben