From: Ben Warren <biggerbadderben@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] net/net.c: correct timeout function
Date: Fri, 05 Dec 2008 13:01:03 -0800 [thread overview]
Message-ID: <4939968F.8010202@gmail.com> (raw)
In-Reply-To: <20081205202952.AF0AC834B020@gemini.denx.de>
Wolfgang Denk wrote:
> Dear Ben Warren,
>
> In message <4938CECF.6090901@gmail.com> you wrote:
>
>>> +static long net_get_timer(long base)
>>> +{
>>> + return get_timer(base) / (CONFIG_SYS_HZ / 1000);
>>> +}
>>> +
>>>
>>>
>> Please change this name to something more meaningful, maybe
>> get_timer_ms(). Apart from that, looks good. If you re-submit soon I'll
>> pull it in.
>>
>
> Please do not pull this. It just covers bugs elsewhere in the code.
>
> We need to fix the real bugs, not put paint and wallpaper over it.
>
> Best regards,
>
> Wolfgang Denk
>
>
OK
prev parent reply other threads:[~2008-12-05 21:01 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-28 16:25 [U-Boot] [PATCH] net/net.c: correct timeout function Daniel Mack
2008-12-03 0:31 ` Daniel Mack
2008-12-03 0:43 ` Ben Warren
2008-12-03 1:05 ` Daniel Mack
2008-12-03 17:57 ` Ben Warren
2008-12-03 0:58 ` Daniel Mack
2008-12-05 6:48 ` Ben Warren
2008-12-05 14:40 ` [U-Boot] [PATCH] net/net.c: add get_timer_ms() Daniel Mack
2008-12-05 20:26 ` Wolfgang Denk
2008-12-05 20:43 ` Daniel Mack
2008-12-05 21:01 ` Wolfgang Denk
2008-12-05 21:07 ` Daniel Mack
2008-12-05 21:16 ` Wolfgang Denk
2008-12-06 16:53 ` Daniel Mack
2008-12-05 20:29 ` [U-Boot] [PATCH] net/net.c: correct timeout function Wolfgang Denk
2008-12-05 21:01 ` Ben Warren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4939968F.8010202@gmail.com \
--to=biggerbadderben@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox