From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Warren Date: Fri, 05 Dec 2008 13:01:03 -0800 Subject: [U-Boot] [PATCH] net/net.c: correct timeout function In-Reply-To: <20081205202952.AF0AC834B020@gemini.denx.de> References: <20081128162529.GA14044@buzzloop.caiaq.de> <20081203005808.GD2012@buzzloop.caiaq.de> <4938CECF.6090901@gmail.com> <20081205202952.AF0AC834B020@gemini.denx.de> Message-ID: <4939968F.8010202@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Wolfgang Denk wrote: > Dear Ben Warren, > > In message <4938CECF.6090901@gmail.com> you wrote: > >>> +static long net_get_timer(long base) >>> +{ >>> + return get_timer(base) / (CONFIG_SYS_HZ / 1000); >>> +} >>> + >>> >>> >> Please change this name to something more meaningful, maybe >> get_timer_ms(). Apart from that, looks good. If you re-submit soon I'll >> pull it in. >> > > Please do not pull this. It just covers bugs elsewhere in the code. > > We need to fix the real bugs, not put paint and wallpaper over it. > > Best regards, > > Wolfgang Denk > > OK