public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Dirk Behme <dirk.behme@googlemail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH-OMAP3] OMAP3: Check for MMC card
Date: Sun, 07 Dec 2008 17:46:34 +0100	[thread overview]
Message-ID: <493BFDEA.7050903@googlemail.com> (raw)
In-Reply-To: <20081206174633.GH2977@game.jcrosoft.org>

Jean-Christophe PLAGNIOL-VILLARD wrote:
>>-	fat_register_device(&mmc_blk_dev, 1);
>>-	return 0;
>>+	if (configure_mmc(&cur_card_data) == 1) {
>>+		mmc_blk_dev.if_type = IF_TYPE_MMC;
>>+		mmc_blk_dev.part_type = PART_TYPE_DOS;
>>+		mmc_blk_dev.dev = 0;
>>+		mmc_blk_dev.lun = 0;
>>+		mmc_blk_dev.type = 0;
>>+
>>+		/* FIXME fill in the correct size (is set to 32MByte) */
>>+		mmc_blk_dev.blksz = MMCSD_SECTOR_SIZE;
>>+		mmc_blk_dev.lba = 0x10000;
>>+		mmc_blk_dev.removable = 0;
>>+		mmc_blk_dev.block_read = mmc_bread;
>>+
>>+		fat_register_device(&mmc_blk_dev, 1);
>>+		return 0;
>>+	} else return 1;
> 
> please use
> 	} else {
> 		return 1;
> 	}
> 
> just return 1;

This and all other pending OMAP3 patches:

http://www.sakoman.net/cgi-bin/gitweb.cgi?p=u-boot-arm.git;a=shortlog;h=refs/heads/omap3-j24

Many thanks to Steve for this!

Best regards

Dirk

Btw.: I heard doing this took ~3min ;)

      reply	other threads:[~2008-12-07 16:46 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-06  7:00 [U-Boot] [PATCH-OMAP3] OMAP3: Check for MMC card Dirk Behme
2008-12-06 16:37 ` Jason Kridner
2008-12-06 17:46 ` Jean-Christophe PLAGNIOL-VILLARD
2008-12-07 16:46   ` Dirk Behme [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=493BFDEA.7050903@googlemail.com \
    --to=dirk.behme@googlemail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox