From: Ben Warren <biggerbadderben@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 1/2] ppc4xx: Add 440EPx SPI driver
Date: Mon, 08 Dec 2008 22:38:08 -0800 [thread overview]
Message-ID: <493E1250.3050105@gmail.com> (raw)
In-Reply-To: <20081209063120.62C68834B020@gemini.denx.de>
Wolfgang Denk wrote:
> Dear Stefan Roese,
>
> In message <200812090638.36452.sr@denx.de> you wrote:
>
>>> Regarding Ben's comments:
>>>
>>> First, thanks for reviewing. You gave me two different approaches to
>>> consider, 1) using in/out functions, and 2) using a structure. So, for
>>> this version, I've followed the style of the example you gave, using the
>>> structure approach.
>>>
>> No, you _need_ to use the in_/out_() accessor functions. This is unrelated to
>> using plain addresses and offsets vs. a structure. I really welcome the
>> change to the structure in this version, so please just add the in_()/out_()
>> functions upon accessing the SoC registers.
>>
>
> Hm... Seems this is a reply to an off-list message?
>
> Steven, please make sure to keep the ML on Cc: !
>
> Best regards,
>
> Wolfgang Denk
>
>
Looks on-list to me:
http://article.gmane.org/gmane.comp.boot-loaders.u-boot/51194
regards,
Ben
next prev parent reply other threads:[~2008-12-09 6:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-08 20:56 [U-Boot] [PATCH v2 1/2] ppc4xx: Add 440EPx SPI driver Steven A. Falco
2008-12-09 5:38 ` Stefan Roese
2008-12-09 6:31 ` Wolfgang Denk
2008-12-09 6:38 ` Ben Warren [this message]
2008-12-09 7:19 ` Stefan Roese
2008-12-09 5:41 ` Stefan Roese
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=493E1250.3050105@gmail.com \
--to=biggerbadderben@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox