From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ben Warren <biggerbadderben@gmail.com>
Date: Mon, 08 Dec 2008 22:38:08 -0800
Subject: [U-Boot] [PATCH v2 1/2] ppc4xx: Add 440EPx SPI driver
In-Reply-To: <20081209063120.62C68834B020@gemini.denx.de>
References: <493D89F8.40103@harris.com> <200812090638.36452.sr@denx.de>
	<20081209063120.62C68834B020@gemini.denx.de>
Message-ID: <493E1250.3050105@gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Wolfgang Denk wrote:
> Dear Stefan Roese,
>
> In message <200812090638.36452.sr@denx.de> you wrote:
>   
>>> Regarding Ben's comments:
>>>
>>> First, thanks for reviewing.  You gave me two different approaches to
>>> consider, 1) using in/out functions, and 2) using a structure.  So, for
>>> this version, I've followed the style of the example you gave, using the
>>> structure approach.
>>>       
>> No, you _need_ to use the in_/out_() accessor functions. This is unrelated to 
>> using plain addresses and offsets vs. a structure. I really welcome the 
>> change to the structure in this version, so please just add the in_()/out_() 
>> functions upon accessing the SoC registers.
>>     
>
> Hm... Seems this is a reply to an off-list message?
>
> Steven, please make sure to keep the ML on Cc: !
>
> Best regards,
>
> Wolfgang Denk
>
>   
Looks on-list to me:

http://article.gmane.org/gmane.comp.boot-loaders.u-boot/51194

regards,
Ben