public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Steven A. Falco <sfalco@harris.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 2/2] ppc4xx: Add PPC4xx SPI helpers to Sequoia
Date: Tue, 09 Dec 2008 14:07:36 -0500	[thread overview]
Message-ID: <493EC1F8.7080107@harris.com> (raw)
In-Reply-To: <20081209185341.71DAD834B020@gemini.denx.de>

Wolfgang Denk wrote:
> Dear Ben Warren,
> 
> In message <493EA876.7090008@gmail.com> you wrote:
>> Why not enable this feature on Sequoia?  Wolfgang's argument for keeping 
>> the patch out then goes away.  IMHO, eval boards should have as many 
>> options enabled by default as possible, and the user then has the option 
>> to opt out.
> 
> But there is not a single SPI device on the Sequoia board, and if you
> attach one, you have to write driver code for it that implements  the
> chip  select handling and the specific device protocol. We would have
> a driver included, without any  "users"  (code  that  actually  calls
> these functions).
> 
> In other words, this driver is a prerequisite for  other  SPI  device
> drivers  that  might  follow  later,  but as is, it's just a waste of
> memory.
> 
> It would just waste memory to enable it.
Makes sense.
> 
> Best regards,
> 
> Wolfgang Denk
> 
The problem is that if it isn't accepted now, nobody is likely to remember
that it is available, and so they will have to re-write it.  Also, it will
suffer from bit-rot, if just left as a loose patch.

	Steve

  reply	other threads:[~2008-12-09 19:07 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-09 16:26 [U-Boot] [PATCH v3 2/2] ppc4xx: Add PPC4xx SPI helpers to Sequoia Steven A. Falco
2008-12-09 16:51 ` Wolfgang Denk
2008-12-09 17:18 ` Ben Warren
2008-12-09 17:28   ` Steven A. Falco
2008-12-09 18:53   ` Wolfgang Denk
2008-12-09 19:07     ` Steven A. Falco [this message]
2008-12-09 19:12       ` Stefan Roese
2008-12-09 19:52         ` Wolfgang Denk
2008-12-09 19:47       ` Wolfgang Denk
2008-12-09 19:11     ` Ben Warren
2008-12-09 20:38       ` Steven A. Falco

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=493EC1F8.7080107@harris.com \
    --to=sfalco@harris.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox