[U-Boot] [PATCH v3 2/2] ppc4xx: Add PPC4xx SPI helpers to Sequoia

Wolfgang Denk
2008-12-09T19:52:14Z

Dear Stefan,

In message <200812092012.02201.sr@denx.de> you wrote:
> On Tuesday 09 December 2008, Steven A. Falco wrote:
> > The problem is that if it isn't accepted now, nobody is likely to remember
> > that it is available, and so they will have to re-write it. Also, it will
> > suffer from bit-rot, if just left as a loose patch.
>
> Full ack from me on this.

I agree - but what is a dead driver without users good for?

What was it written for? ... obviously for some specific application
on some real board. I recommend to submit this driver as part of the
patch series that adds this board support to U-Boot. Then we will
also have at least one real user of that code, i. e. we can make sure
that it at least compiles.

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"The value of marriage is not that adults produce children, but that
children produce adults." - Peter De Vries