[U-Boot] [PATCH v3 2/2] ppc4xx: Add PPC4xx SPI helpers to Sequoia

Wolfgang Denk
2008-12-09T18:53:41Z

Dear Ben Warren,

In message <493EA876.7090008@gmail.com> you wrote:
>
> Why not enable this feature on Sequoia? Wolfgang's argument for keeping
> the patch out then goes away. IMHO, eval boards should have as many
> options enabled by default as possible, and the user then has the option
> to opt out.

But there is not a single SPI device on the Sequoia board, and if you
attach one, you have to write driver code for it that implements the
chip select handling and the specific device protocol. We would have
a driver included, without any "users" (code that actually calls
these functions).

In other words, this driver is a prerequisite for other SPI device
drivers that might follow later, but as is, it's just a waste of
memory.

It would just waste memory to enable it.

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Women are more easily and more deeply terrified ... generating more
sheer horror than the male of the species.
-- Spock, "Wolf in the Fold", stardate 3615.4